Disable X509Store_FiltersDuplicateOnLoad on CI jobs with NTFS drives

mellinoe · mellinoe · commit 397d986b4b43 · 2016-11-04T18:09:49.000-07:00
diff --git a/src/System.Security.Cryptography.X509Certificates/tests/X509FilesystemTests.Unix.cs b/src/System.Security.Cryptography.X509Certificates/tests/X509FilesystemTests.Unix.cs
@@ -15,7 +15,7 @@ namespace System.Security.Cryptography.X509Certificates.Tests
     [Collection("X509Filesystem")]
     public static class X509FilesystemTests
     {
-        // #9293: Our Fedora23 CI machines use NTFS for "tmphome", which causes our filesystem permissions checks to fail.
+        // #9293: Our Fedora23 and Ubuntu1610 CI machines use NTFS for "tmphome", which causes our filesystem permissions checks to fail.
         private static bool IsReliableInCI { get; } = !PlatformDetection.IsFedora23 && !PlatformDetection.IsUbuntu1610;
 
         [Fact]
@@ -576,7 +576,7 @@ private static void X509Store_MultipleObjects(bool matchCase)
                 });
         }
 
-        [Fact]
+        [ConditionalFact(nameof(IsReliableInCI))]
         [OuterLoop( /* Alters user/machine state */)]
         private static void X509Store_FiltersDuplicateOnLoad()
         {

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ namespace System.Security.Cryptography.X509Certificates.Tests`
`15`	`15`	`[Collection("X509Filesystem")]`
`16`	`16`	`public static class X509FilesystemTests`
`17`	`17`	`{`
`18`		`- // #9293: Our Fedora23 CI machines use NTFS for "tmphome", which causes our filesystem permissions checks to fail.`
	`18`	`+ // #9293: Our Fedora23 and Ubuntu1610 CI machines use NTFS for "tmphome", which causes our filesystem permissions checks to fail.`
`19`	`19`	`private static bool IsReliableInCI { get; } = !PlatformDetection.IsFedora23 && !PlatformDetection.IsUbuntu1610;`
`20`	`20`
`21`	`21`	`[Fact]`
`@@ -576,7 +576,7 @@ private static void X509Store_MultipleObjects(bool matchCase)`
`576`	`576`	`});`
`577`	`577`	`}`
`578`	`578`
`579`		`- [Fact]`
	`579`	`+ [ConditionalFact(nameof(IsReliableInCI))]`
`580`	`580`	`[OuterLoop( /* Alters user/machine state */)]`
`581`	`581`	`private static void X509Store_FiltersDuplicateOnLoad()`
`582`	`582`	`{`