Skip to content

Commit f005c7a

Browse files
Copilotdavidfowl
andcommitted
Remove obsolete DotNetTemplateFactoryTests that check feature-disabled scenarios
Co-authored-by: davidfowl <[email protected]>
1 parent 27f066b commit f005c7a

File tree

1 file changed

+5
-52
lines changed

1 file changed

+5
-52
lines changed

tests/Aspire.Cli.Tests/Templating/DotNetTemplateFactoryTests.cs

Lines changed: 5 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -307,40 +307,10 @@ public void GetTemplates_WhenShowAllTemplatesIsDisabled_ReturnsOnlyStarterTempla
307307
}
308308

309309
[Fact]
310-
public void GetTemplates_WhenShowAllTemplatesIsDisabled_SingleFileAppHostIsVisibleIfFeatureEnabled()
310+
public void GetTemplates_SingleFileAppHostIsAlwaysVisible()
311311
{
312-
// Arrange - disable showAllTemplates but enable singleFileAppHost
313-
var features = new TestFeatures(showAllTemplates: false, singleFileAppHostEnabled: true);
314-
var factory = CreateTemplateFactory(features);
315-
316-
// Act
317-
var templates = factory.GetTemplates().ToList();
318-
319-
// Assert
320-
var templateNames = templates.Select(t => t.Name).ToList();
321-
Assert.Contains("aspire-apphost-singlefile", templateNames);
322-
}
323-
324-
[Fact]
325-
public void GetTemplates_WhenShowAllTemplatesIsDisabled_SingleFileAppHostIsHiddenIfFeatureDisabled()
326-
{
327-
// Arrange - disable both showAllTemplates and singleFileAppHost
328-
var features = new TestFeatures(showAllTemplates: false, singleFileAppHostEnabled: false);
329-
var factory = CreateTemplateFactory(features);
330-
331-
// Act
332-
var templates = factory.GetTemplates().ToList();
333-
334-
// Assert
335-
var templateNames = templates.Select(t => t.Name).ToList();
336-
Assert.DoesNotContain("aspire-apphost-singlefile", templateNames);
337-
}
338-
339-
[Fact]
340-
public void GetTemplates_WhenShowAllTemplatesIsEnabled_SingleFileAppHostIsVisibleIfFeatureEnabled()
341-
{
342-
// Arrange - enable showAllTemplates and enable singleFileAppHost
343-
var features = new TestFeatures(showAllTemplates: true, singleFileAppHostEnabled: true);
312+
// Arrange - single-file templates should always be visible now
313+
var features = new TestFeatures(showAllTemplates: false);
344314
var factory = CreateTemplateFactory(features);
345315

346316
// Act
@@ -349,21 +319,7 @@ public void GetTemplates_WhenShowAllTemplatesIsEnabled_SingleFileAppHostIsVisibl
349319
// Assert
350320
var templateNames = templates.Select(t => t.Name).ToList();
351321
Assert.Contains("aspire-apphost-singlefile", templateNames);
352-
}
353-
354-
[Fact]
355-
public void GetTemplates_WhenShowAllTemplatesIsEnabled_SingleFileAppHostIsHiddenIfFeatureDisabled()
356-
{
357-
// Arrange - enable showAllTemplates but disable singleFileAppHost
358-
var features = new TestFeatures(showAllTemplates: true, singleFileAppHostEnabled: false);
359-
var factory = CreateTemplateFactory(features);
360-
361-
// Act
362-
var templates = factory.GetTemplates().ToList();
363-
364-
// Assert
365-
var templateNames = templates.Select(t => t.Name).ToList();
366-
Assert.DoesNotContain("aspire-apphost-singlefile", templateNames);
322+
Assert.Contains("aspire-py-starter", templateNames);
367323
}
368324

369325
private static DotNetTemplateFactory CreateTemplateFactory(TestFeatures features)
@@ -391,20 +347,17 @@ private static DotNetTemplateFactory CreateTemplateFactory(TestFeatures features
391347
private sealed class TestFeatures : IFeatures
392348
{
393349
private readonly bool _showAllTemplates;
394-
private readonly bool _singleFileAppHostEnabled;
395350

396-
public TestFeatures(bool showAllTemplates = false, bool singleFileAppHostEnabled = false)
351+
public TestFeatures(bool showAllTemplates = false)
397352
{
398353
_showAllTemplates = showAllTemplates;
399-
_singleFileAppHostEnabled = singleFileAppHostEnabled;
400354
}
401355

402356
public bool IsFeatureEnabled(string featureFlag, bool defaultValue)
403357
{
404358
return featureFlag switch
405359
{
406360
"showAllTemplates" => _showAllTemplates,
407-
"singlefileAppHostEnabled" => _singleFileAppHostEnabled,
408361
_ => defaultValue
409362
};
410363
}

0 commit comments

Comments
 (0)