Remove vstest special version handling (#2257)

MichaelSimons · web-flow · commit ba02feddac8c · 2023-04-06T16:42:33.000-07:00
* Remove vstest special version handling

* Remove special testcase for vstest
diff --git a/build.sh b/build.sh
diff --git a/src/Microsoft.DotNet.Darc/src/DarcLib/Helpers/VersionFiles.cs b/src/Microsoft.DotNet.Darc/src/DarcLib/Helpers/VersionFiles.cs
@@ -85,12 +85,6 @@ public static (string BuildId, string ReleaseLabel) DeriveBuildInfo(string repoN
 
         if (releaseParts.Length == 3)
         {
-            // VSTest uses full dates for the first part of their preview build numbers
-            if (repoName.Contains("vstest"))
-            {
-                return ($"{releaseParts[1]}.{releaseParts[2]}", releaseParts[0]);
-            }
-                
             if (int.TryParse(releaseParts[1], out int datePart) && int.TryParse(releaseParts[2], out int buildPart))
             {
                 if (datePart > 1 && datePart < 8 && buildPart > 1000 && buildPart < 10000)
diff --git a/src/Microsoft.DotNet.Darc/tests/Microsoft.DotNet.DarcLib.Tests/Helpers/VersionFileTests.cs b/src/Microsoft.DotNet.Darc/tests/Microsoft.DotNet.DarcLib.Tests/Helpers/VersionFileTests.cs
@@ -32,13 +32,6 @@ public void OldPreviewVersionIsDerivedTest()
             .Should().Be((DateTime.Now.ToString("20220413.1"), "beta"));
     }
 
-    [Test]
-    public void VsTestVersionIsDerivedTest()
-    {
-        VersionFiles.DeriveBuildInfo("vstest", "17.4.0-preview-20220813-01")
-            .Should().Be((DateTime.Now.ToString("20220813.01"), "preview"));
-    }
-
     [Test]
     public void NewPreviewVersionIsDerivedTest()
     {

Original file line number	Diff line number	Diff line change
`@@ -85,12 +85,6 @@ public static (string BuildId, string ReleaseLabel) DeriveBuildInfo(string repoN`
`85`	`85`
`86`	`86`	`if (releaseParts.Length == 3)`
`87`	`87`	`{`
`88`		`- // VSTest uses full dates for the first part of their preview build numbers`
`89`		`- if (repoName.Contains("vstest"))`
`90`		`- {`
`91`		`- return ($"{releaseParts[1]}.{releaseParts[2]}", releaseParts[0]);`
`92`		`- }`
`93`		`-`
`94`	`88`	`if (int.TryParse(releaseParts[1], out int datePart) && int.TryParse(releaseParts[2], out int buildPart))`
`95`	`89`	`{`
`96`	`90`	`if (datePart > 1 && datePart < 8 && buildPart > 1000 && buildPart < 10000)`
Original file line number	Diff line number	Diff line change
`@@ -32,13 +32,6 @@ public void OldPreviewVersionIsDerivedTest()`
`32`	`32`	`.Should().Be((DateTime.Now.ToString("20220413.1"), "beta"));`
`33`	`33`	`}`
`34`	`34`
`35`		`- [Test]`
`36`		`- public void VsTestVersionIsDerivedTest()`
`37`		`- {`
`38`		`- VersionFiles.DeriveBuildInfo("vstest", "17.4.0-preview-20220813-01")`
`39`		`- .Should().Be((DateTime.Now.ToString("20220813.01"), "preview"));`
`40`		`- }`
`41`		`-`
`42`	`35`	`[Test]`
`43`	`36`	`public void NewPreviewVersionIsDerivedTest()`
`44`	`37`	`{`