Skip to content

Commit fb90280

Browse files
committed
Formatting and comments
1 parent 0de78f9 commit fb90280

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,9 @@
4949
<!--
5050
Android package (apt/aab) alignment, expressed as the page size in kilobytes. Two values are supported: 4 and 16.
5151
Sometime next year the default value should be changed to 16 since it's going to be a Google Play store requirement for
52-
application submissions
52+
application submissions.
53+
54+
When changing this default, change the value of `DefaultZipAlignment` in `src/Xamarin.Android.Build.Tasks/Tasks/AndroidZipAlign.cs` as well
5355
-->
5456
<_AndroidZipAlignment Condition=" '$(_AndroidZipAlignment)' == '' ">16</_AndroidZipAlignment>
5557
</PropertyGroup>

src/Xamarin.Android.Build.Tasks/Xamarin.Android.Common.targets

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2356,8 +2356,8 @@ because xbuild doesn't support framework reference assemblies.
23562356
<Delete Files="%(ApkAbiFilesSigned.FullPath)" Condition=" '$(AndroidUseApkSigner)' == 'true' "/>
23572357
<AndroidZipAlign Condition=" '$(AndroidUseApkSigner)' == 'true' "
23582358
Source="%(ApkAbiFilesIntermediate.Identity)"
2359-
Alignment="$(_AndroidZipAlignment)"
2360-
DestinationDirectory="$(OutDir)"
2359+
Alignment="$(_AndroidZipAlignment)"
2360+
DestinationDirectory="$(OutDir)"
23612361
ToolPath="$(ZipAlignToolPath)"
23622362
ToolExe="$(ZipalignToolExe)"
23632363
/>
@@ -2392,8 +2392,8 @@ because xbuild doesn't support framework reference assemblies.
23922392
<Message Text="Unaligned android package '%(ApkAbiFilesUnaligned.FullPath)'" Condition=" '$(AndroidUseApkSigner)' != 'True' And '$(AndroidPackageFormat)' != 'aab' "/>
23932393
<AndroidZipAlign Condition=" '$(AndroidUseApkSigner)' != 'True' And '$(AndroidPackageFormat)' != 'aab' "
23942394
Source="%(ApkAbiFilesUnaligned.Identity)"
2395-
Alignment="$(_AndroidZipAlignment)"
2396-
DestinationDirectory="$(OutDir)"
2395+
Alignment="$(_AndroidZipAlignment)"
2396+
DestinationDirectory="$(OutDir)"
23972397
ToolPath="$(ZipAlignToolPath)"
23982398
ToolExe="$(ZipalignToolExe)"
23992399
/>

0 commit comments

Comments
 (0)