[tests] update MSBuild performance tests

It's been a while, since I went through and refactored these tests.
After seeing a couple build-time regressions in .NET 9, I think it's
overdue.

Removing test cases that likely won't catch an issue:

* `Build_Designer_Change` (less concerned about designer now)
* `Build_CSProj_Change`

`Build_From_Clean_DontIncludeRestore` would likely catch similar
issues as these two, anyway.

`Build_XAML_Change_RefAssembly` now uses a `net8.0` class library
where `$(ProduceReferenceAssembly)` defaults to `true`.

Removed a 500ms addition, that only made sense when we supported both
"classic" Xamarin.Android and .NET 6+ projects.

Update the time thresholds to be a bit shorter, in general.

Author: jonathanpeppers

tests/MSBuildDeviceIntegration/Tests/PerformanceTest.cs

@@ -50,9 +50,6 @@ void Profile (ProjectBuilder builder, Action<ProjectBuilder> action, [CallerMemb
 				Assert.Fail ($"No timeout value found for a key of {caller}");
 			}
 
-			//TODO: Update baselines in MSBuildDeviceIntegration.csv, there is currently a slight performance regression in .NET 6
-			expected += 500;
-
 			action (builder);
 			var actual = GetDurationFromBinLog (builder);
 			TestContext.Out.WriteLine($"expected: {expected}ms, actual: {actual}ms");
@@ -203,27 +200,6 @@ public void Build_AndroidAsset_Change ()
 			}
 		}
 
-		[Test]
-		[Retry (Retry)]
-		public void Build_Designer_Change ()
-		{
-			var proj = CreateApplicationProject ();
-			using (var builder = CreateBuilderWithoutLogFile ()) {
-				builder.Target = "Build";
-				builder.Build (proj);
-				builder.AutomaticNuGetRestore = false;
-
-				// Change AndroidResource & run SetupDependenciesForDesigner
-				proj.LayoutMain += $"{Environment.NewLine}<!--comment-->";
-				proj.Touch ("Resources\\layout\\Main.axml");
-				var parameters = new [] { "DesignTimeBuild=True", "AndroidUseManagedDesignTimeResourceGenerator=False" };
-				builder.RunTarget (proj, "SetupDependenciesForDesigner", parameters: parameters);
-
-				// Profile AndroidResource change
-				Profile (builder, b => b.Build (proj));
-			}
-		}
-
 		[Test]
 		[Retry (Retry)]
 		public void Build_JLO_Change ()
@@ -263,43 +239,9 @@ public void Build_AndroidManifest_Change ()
 		}
 
 		[Test]
-		[Retry (Retry)]
-		public void Build_CSProj_Change ()
-		{
-			var proj = CreateApplicationProject ();
-			using (var builder = CreateBuilderWithoutLogFile ()) {
-				builder.Target = "Build";
-				builder.Build (proj);
-				builder.AutomaticNuGetRestore = false;
-
-				// Profile .csproj change
-				proj.Sources.Add (new BuildItem ("None", "Foo.txt") {
-					TextContent = () => "Bar",
-				});
-				Profile (builder, b => b.Build (proj));
-			}
-		}
-
-		static object [] XAML_Change = new object [] {
-			new object [] {
-				/* produceReferenceAssembly */ false,
-				/* install */                  false,
-			},
-			new object [] {
-				/* produceReferenceAssembly */ true,
-				/* install */                  false,
-			},
-			new object [] {
-				/* produceReferenceAssembly */ true,
-				/* install */                  true,
-			},
-		};
-
-		[Test]
-		[TestCaseSource (nameof (XAML_Change))]
 		[Category ("UsesDevice")]
 		[Retry (Retry)]
-		public void Build_XAML_Change (bool produceReferenceAssembly, bool install)
+		public void Build_XAML_Change ([Values (true, false)] bool install)
 		{
 			if (install) {
 				AssertCommercialBuild (); // This test will fail without Fast Deployment
@@ -315,8 +257,6 @@ public void Build_XAML_Change (bool produceReferenceAssembly, bool install)
 			var caller = nameof (Build_XAML_Change);
 			if (install) {
 				caller = caller.Replace ("Build", "Install");
-			} else if (produceReferenceAssembly) {
-				caller += "_RefAssembly";
 			}
 			var app = CreateApplicationProject ();
 			app.ProjectName = "MyApp";
@@ -332,7 +272,7 @@ public void Build_XAML_Change (bool produceReferenceAssembly, bool install)
 			var lib = new DotNetStandard {
 				ProjectName = "MyLibrary",
 				Sdk = "Microsoft.NET.Sdk",
-				TargetFramework = "netstandard2.0",
+				TargetFramework = "net8.0", // Vanilla project
 				Sources = {
 					new BuildItem.Source ("Bar.cs") {
 						TextContent = () => "public class Bar { public Bar () { System.Console.WriteLine (" + count++ + "); } }"
@@ -345,7 +285,6 @@ public void Build_XAML_Change (bool produceReferenceAssembly, bool install)
 					KnownPackages.XamarinForms,
 				}
 			};
-			lib.SetProperty ("ProduceReferenceAssembly", produceReferenceAssembly.ToString ());
 			app.References.Add (new BuildItem.ProjectReference ($"..\\{lib.ProjectName}\\{lib.ProjectName}.csproj", lib.ProjectName, lib.ProjectGuid));
 
 			using (var libBuilder = CreateBuilderWithoutLogFile (Path.Combine (path, lib.ProjectName), isApp: false))

tests/msbuild-times-reference/MSBuildDeviceIntegration.csv

@@ -3,15 +3,12 @@
 Test Name,Time in ms (int)
 # Data
 Build_From_Clean_DontIncludeRestore,13000
-Build_No_Changes,2500
-Build_CSharp_Change,4000
-Build_AndroidResource_Change,3250
-Build_AndroidAsset_Change,10000
+Build_No_Changes,2250
+Build_CSharp_Change,3500
+Build_AndroidResource_Change,2250
+Build_AndroidAsset_Change,6500
 Build_AndroidManifest_Change,4500
-Build_Designer_Change,3000
-Build_JLO_Change,10000
-Build_CSProj_Change,12500
-Build_XAML_Change,7400
-Build_XAML_Change_RefAssembly,4000
-Install_CSharp_Change,4500
-Install_XAML_Change,5000
+Build_JLO_Change,4500
+Build_XAML_Change,3000
+Install_CSharp_Change,4000
+Install_XAML_Change,3750