Skip to content

Commit 94b31be

Browse files
pjcollinsjonathanpeppers
pjcollins
authored and
jonathanpeppers
committed
[build] Do not install build-tools 30.0.3 (#8461)
Context: 6eb11f1 We do not need to provision build-tools version 30.0.3 as `dx` is no longer supported.
1 parent 71eb027 commit 94b31be

File tree

6 files changed

+0
-46
lines changed

6 files changed

+0
-46
lines changed

‎Configuration.props

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -137,14 +137,6 @@
137137
<XABuildToolsPackagePrefix Condition=" '$(HostOS)' == 'Windows' ">$(XABuildToolsPackagePrefixWindows)</XABuildToolsPackagePrefix>
138138
<XABuildToolsVersion>34</XABuildToolsVersion>
139139
<XABuildToolsFolder Condition="'$(XABuildToolsFolder)' == ''">34.0.0</XABuildToolsFolder>
140-
<!-- build-tools 30, for DX tests -->
141-
<XABuildTools30PackagePrefixMacOS>f6d24b187cc6bd534c6c37604205171784ac5621.</XABuildTools30PackagePrefixMacOS>
142-
<XABuildTools30PackagePrefixWindows>91936d4ee3ccc839f0addd53c9ebf087b1e39251.</XABuildTools30PackagePrefixWindows>
143-
<XABuildTools30PackagePrefixLinux></XABuildTools30PackagePrefixLinux>
144-
<XABuildTools30PackagePrefix Condition=" '$(HostOS)' == 'Darwin' ">$(XABuildTools30PackagePrefixMacOS)</XABuildTools30PackagePrefix>
145-
<XABuildTools30PackagePrefix Condition=" '$(HostOS)' == 'Windows' ">$(XABuildTools30PackagePrefixWindows)</XABuildTools30PackagePrefix>
146-
<XABuildTools30Version>30.0.3</XABuildTools30Version>
147-
<XABuildTools30Folder Condition="'$(XABuildTools30Folder)' == ''">30.0.3</XABuildTools30Folder>
148140
<XAPlatformToolsPackagePrefix Condition=" '$(HostOS)' == 'Darwin' "></XAPlatformToolsPackagePrefix>
149141
<XAPlatformToolsVersion>34.0.1</XAPlatformToolsVersion>
150142
<XAIncludeProprietaryBits Condition="'$(XAIncludeProprietaryBits)' == ''">False</XAIncludeProprietaryBits>

‎build-tools/xaprepare/xaprepare/Application/KnownProperties.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -65,12 +65,6 @@ static class KnownProperties
6565
public const string XABuildToolsPackagePrefixWindows = "XABuildToolsPackagePrefixWindows";
6666
public const string XABuildToolsPackagePrefixLinux = "XABuildToolsPackagePrefixLinux";
6767
public const string XABuildToolsPackagePrefix = "XABuildToolsPackagePrefix";
68-
public const string XABuildTools30Folder = "XABuildTools30Folder";
69-
public const string XABuildTools30Version = "XABuildTools30Version";
70-
public const string XABuildTools30PackagePrefixMacOS = "XABuildTools30PackagePrefixMacOS";
71-
public const string XABuildTools30PackagePrefixWindows = "XABuildTools30PackagePrefixWindows";
72-
public const string XABuildTools30PackagePrefixLinux = "XABuildTools30PackagePrefixLinux";
73-
public const string XABuildTools30PackagePrefix = "XABuildTools30PackagePrefix";
7468
public const string XABinRelativeInstallPrefix = "XABinRelativeInstallPrefix";
7569
public const string XAInstallPrefix = "XAInstallPrefix";
7670
public const string XAPlatformToolsVersion = "XAPlatformToolsVersion";

‎build-tools/xaprepare/xaprepare/Application/Properties.Defaults.cs.in

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -69,12 +69,6 @@ namespace Xamarin.Android.Prepare
6969
properties.Add (KnownProperties.XABuildToolsPackagePrefixWindows, StripQuotes ("@XABuildToolsPackagePrefixWindows@"));
7070
properties.Add (KnownProperties.XABuildToolsPackagePrefixLinux, StripQuotes ("@XABuildToolsPackagePrefixLinux@"));
7171
properties.Add (KnownProperties.XABuildToolsPackagePrefix, StripQuotes ("@XABuildToolsPackagePrefix@"));
72-
properties.Add (KnownProperties.XABuildTools30Folder, StripQuotes (@"@XABuildTools30Folder@"));
73-
properties.Add (KnownProperties.XABuildTools30Version, StripQuotes ("@XABuildTools30Version@"));
74-
properties.Add (KnownProperties.XABuildTools30PackagePrefixMacOS, StripQuotes ("@XABuildTools30PackagePrefixMacOS@"));
75-
properties.Add (KnownProperties.XABuildTools30PackagePrefixWindows, StripQuotes ("@XABuildTools30PackagePrefixWindows@"));
76-
properties.Add (KnownProperties.XABuildTools30PackagePrefixLinux, StripQuotes ("@XABuildTools30PackagePrefixLinux@"));
77-
properties.Add (KnownProperties.XABuildTools30PackagePrefix, StripQuotes ("@XABuildTools30PackagePrefix@"));
7872
properties.Add (KnownProperties.XABinRelativeInstallPrefix, StripQuotes (@"@XABinRelativeInstallPrefix@"));
7973
properties.Add (KnownProperties.XAInstallPrefix, StripQuotes (@"@XAInstallPrefix@"));
8074
properties.Add (KnownProperties.XAPlatformToolsVersion, StripQuotes ("@XAPlatformToolsVersion@"));

‎build-tools/xaprepare/xaprepare/ConfigAndData/Dependencies/AndroidToolchain.cs

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@ public AndroidToolchain ()
2626
string XABuildToolsFolder = GetRequiredProperty (KnownProperties.XABuildToolsFolder);
2727
string XABuildToolsVersion = GetRequiredProperty (KnownProperties.XABuildToolsVersion);
2828
string XABuildToolsPackagePrefix = Context.Instance.Properties [KnownProperties.XABuildToolsPackagePrefix] ?? String.Empty;
29-
string XABuildTools30Folder = GetRequiredProperty (KnownProperties.XABuildTools30Folder);
30-
string XABuildTools30Version = GetRequiredProperty (KnownProperties.XABuildTools30Version);
31-
string XABuildTools30PackagePrefix = Context.Instance.Properties [KnownProperties.XABuildTools30PackagePrefix] ?? String.Empty;
3229
string XAPlatformToolsVersion = GetRequiredProperty (KnownProperties.XAPlatformToolsVersion);
3330
string XAPlatformToolsPackagePrefix = Context.Instance.Properties [KnownProperties.XAPlatformToolsPackagePrefix] ?? String.Empty;
3431
bool isArm64Apple = Context.Instance.OS.Flavor == "macOS" && RuntimeInformation.OSArchitecture == Architecture.Arm64;
@@ -111,12 +108,6 @@ public AndroidToolchain ()
111108
buildToolName: "android-sdk-build-tools",
112109
buildToolVersion: $"{XABuildToolsVersion}"
113110
),
114-
new AndroidToolchainComponent ($"{XABuildTools30PackagePrefix}build-tools_r{XABuildTools30Version}-{altOsTag}",
115-
destDir: Path.Combine ("build-tools", XABuildTools30Folder),
116-
isMultiVersion: true,
117-
buildToolName: "android-sdk-build-tools",
118-
buildToolVersion: $"{XABuildTools30Version}"
119-
),
120111
new AndroidToolchainComponent ($"commandlinetools-{cltOsTag}-{CommandLineToolsVersion}",
121112
destDir: Path.Combine ("cmdline-tools", CommandLineToolsFolder),
122113
isMultiVersion: true,

‎build-tools/xaprepare/xaprepare/Steps/Step_Get_Android_BuildTools.cs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,6 @@ public Step_Get_Android_BuildTools ()
2121
packages.Add ((package: $"build-tools_r{XABuildToolsVersion}-macosx.zip", prefix: XABuildToolsPackagePrefixMacOS));
2222
packages.Add ((package: $"build-tools_r{XABuildToolsVersion}-windows.zip", prefix: XABuildToolsPackagePrefixWindows));
2323
packages.Add ((package: $"build-tools_r{XABuildToolsVersion}-linux.zip", prefix: XABuildToolsPackagePrefixLinux));
24-
25-
// build-tools 30, for DX tests
26-
string XABuildTools30Version = Context.Instance.Properties [KnownProperties.XABuildTools30Version] ?? String.Empty;
27-
string XABuildTools30PackagePrefixMacOS = Context.Instance.Properties [KnownProperties.XABuildTools30PackagePrefixMacOS] ?? string.Empty;
28-
string XABuildTools30PackagePrefixWindows = Context.Instance.Properties [KnownProperties.XABuildTools30PackagePrefixWindows] ?? string.Empty;
29-
string XABuildTools30PackagePrefixLinux = Context.Instance.Properties [KnownProperties.XABuildTools30PackagePrefixLinux] ?? string.Empty;
30-
if (!string.IsNullOrEmpty (XABuildTools30Version)) {
31-
packages.Add ((package: $"build-tools_r{XABuildTools30Version}-macosx.zip", prefix: XABuildTools30PackagePrefixMacOS));
32-
packages.Add ((package: $"build-tools_r{XABuildTools30Version}-windows.zip", prefix: XABuildTools30PackagePrefixWindows));
33-
packages.Add ((package: $"build-tools_r{XABuildTools30Version}-linux.zip", prefix: XABuildTools30PackagePrefixLinux));
34-
}
3524
}
3625

3726
protected override async Task<bool> Execute (Context context)

‎build-tools/xaprepare/xaprepare/xaprepare.targets

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,6 @@
102102
<Replacement Include="@XABuildToolsPackagePrefixWindows@=$(XABuildToolsPackagePrefixWindows)" />
103103
<Replacement Include="@XABuildToolsPackagePrefixLinux@=$(XABuildToolsPackagePrefixLinux)" />
104104
<Replacement Include="@XABuildToolsPackagePrefix@=$(XABuildToolsPackagePrefix)" />
105-
<Replacement Include="@XABuildTools30Folder@=$(XABuildTools30Folder)" />
106-
<Replacement Include="@XABuildTools30Version@=$(XABuildTools30Version)" />
107-
<Replacement Include="@XABuildTools30PackagePrefixMacOS@=$(XABuildTools30PackagePrefixMacOS)" />
108-
<Replacement Include="@XABuildTools30PackagePrefixWindows@=$(XABuildTools30PackagePrefixWindows)" />
109-
<Replacement Include="@XABuildTools30PackagePrefixLinux@=$(XABuildTools30PackagePrefixLinux)" />
110-
<Replacement Include="@XABuildTools30PackagePrefix@=$(XABuildTools30PackagePrefix)" />
111105
<Replacement Include="@XAPlatformToolsVersion@=$(XAPlatformToolsVersion)" />
112106
<Replacement Include="@XAInstallPrefix@=$(XAInstallPrefix)" />
113107
<Replacement Include="@XABinRelativeInstallPrefix@=$(_XABinRelativeInstallPrefix)" />

0 commit comments

Comments
 (0)