Skip to content

Commit 46bae85

Browse files
[tests] fix GetString_Many() test (#10317)
The test is currently failing with: Expected: True But was: False Stack trace at Xamarin.Android.NetTests.HttpClientIntegrationTestBase.GetString_Many() at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args) at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object , BindingFlags ) If I navigate to http://example.org in a browser, I just get a DNS error. There are other tests in here that use https://google.com instead, so I switched to use it. I also removed the `MobileNotWorking` category, which doesn't appear to be actually ignored because the test is running?
1 parent 510fc08 commit 46bae85

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

tests/BCL-Tests/Xamarin.Android.Bcl-Tests/NUnitInstrumentation.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ void CommonInit ()
4747
"AndroidNotWorking",
4848
"CAS",
4949
"InetAccess",
50-
"MobileNotWorking",
5150
"NotWorking",
5251
};
5352

tests/Mono.Android-Tests/Mono.Android-Tests/Xamarin.Android.Net/HttpClientIntegrationTests.cs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -887,12 +887,11 @@ public void Send_Invalid ()
887887
}
888888

889889
[Test]
890-
[Category ("MobileNotWorking")] // Missing encoding
891890
public void GetString_Many ()
892891
{
893892
var client = new HttpClient (CreateHandler ());
894-
var t1 = client.GetStringAsync ("http://example.org");
895-
var t2 = client.GetStringAsync ("http://example.org");
893+
var t1 = client.GetStringAsync ("https://google.com");
894+
var t2 = client.GetStringAsync ("https://google.com");
896895
Assert.IsTrue (Task.WaitAll (new [] { t1, t2 }, WaitTimeout));
897896
}
898897

0 commit comments

Comments
 (0)