Skip to content

Disable Static Web Assets #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025
Merged

Conversation

martincostello
Copy link
Collaborator

Disable static web assets as it can cause file-write conflicts in parallel builds.

Disable static web assets as it can cause file-write conflicts in parallel builds.
@Copilot Copilot AI review requested due to automatic review settings June 1, 2025 15:11
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables static web assets to avoid file-write conflicts during parallel builds.

  • Added the line to set StaticWebAssetsEnabled to false in Directory.Build.props

@martincostello martincostello enabled auto-merge (rebase) June 1, 2025 15:11
Copy link

codecov bot commented Jun 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.55%. Comparing base (e1287bc) to head (036abd1).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3432   +/-   ##
=======================================
  Coverage   93.55%   93.55%           
=======================================
  Files         110      110           
  Lines        3834     3834           
  Branches      719      719           
=======================================
  Hits         3587     3587           
  Misses        247      247           
Flag Coverage Δ
Linux 93.55% <ø> (ø)
Windows 93.55% <ø> (ø)
macOS 93.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello merged commit c04e798 into master Jun 1, 2025
11 checks passed
@martincostello martincostello deleted the disable-static-web-assets branch June 1, 2025 15:15
This was referenced Jul 28, 2025
This was referenced Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant