Skip to content

[Docs] Split readme md #3405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

peter-csala
Copy link
Contributor

@peter-csala peter-csala commented May 14, 2025

Pull Request

The issue or feature being addressed

Details on the issue fix or feature implementation

  • As a first step to de-monolith the README.md I've created 6 separate md files (one for each configure and customize section).
  • I also updated the readme.md to point ot the new documentation files.

Preview: https://github.com/peter-csala/Swashbuckle.AspNetCore/tree/3365-split-readme-md

Additional stuff:

  • I've changed the headings for the subsection to one level lower
    • in the readme.md the sections start from H2 level
    • in the new md files they start from H1 level
  • I've removed the # suffixes because they are not needed and they were used inconsistenly
  • I've replaced the explicit <h3> tags under the Redoc to markdown syntax

Otherwise the content remain intact.

The next PR will improve the formatting of the markdown files.

@peter-csala
Copy link
Contributor Author

@dotnet-policy-service agree

@peter-csala
Copy link
Contributor Author

@martincostello Could you please review it?

@martincostello
Copy link
Collaborator

I've been travelling for work this week. This is in my TODO pile until I have the time to look at it properly on a computer.

@martincostello
Copy link
Collaborator

martincostello commented May 16, 2025

Could we delete the equivalent content in README in this PR too please? Then we won't have the content in two places.

It can be as simple as leaving the headings in place with a simple "See here" link to each section that links to the new page. We can make it look nicer later on.

Otherwise LGTM.

@peter-csala
Copy link
Contributor Author

Could we delete the equivalent content in README in this PR too please? Then we won't have the content in two places.

It can be as simple as leaving the headings in place with a simple "See here" link to each section that links to the new page. We can make it look nicer later on.

Otherwise LGTM.

Done

@peter-csala peter-csala force-pushed the 3365-split-readme-md branch from 5412b84 to 44fb768 Compare May 18, 2025 11:09
Copy link
Collaborator

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@martincostello martincostello enabled auto-merge (squash) May 18, 2025 15:44
@codecov-commenter
Copy link

codecov-commenter commented May 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.55%. Comparing base (1c0259f) to head (70c0545).
Report is 2 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3405      +/-   ##
==========================================
+ Coverage   83.65%   93.55%   +9.90%     
==========================================
  Files          84      110      +26     
  Lines        3291     3834     +543     
  Branches      579      719     +140     
==========================================
+ Hits         2753     3587     +834     
+ Misses        538      247     -291     
Flag Coverage Δ
Linux 93.55% <ø> (+9.90%) ⬆️
Windows 93.55% <ø> (+9.90%) ⬆️
macOS 93.55% <ø> (+9.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello merged commit 91b05c6 into domaindrivendev:master May 18, 2025
9 checks passed
martincostello added a commit that referenced this pull request Jun 1, 2025
Fix link to documentation broken by #3405.
@martincostello martincostello mentioned this pull request Jun 1, 2025
martincostello added a commit that referenced this pull request Jun 1, 2025
Fix link to documentation broken by #3405.
This was referenced Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants