Update to fix Lists/Arrays of nullables not getting marked as nullable #3364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3364 +/- ##
==========================================
- Coverage 84.74% 83.47% -1.28%
==========================================
Files 84 84
Lines 3278 3280 +2
Branches 571 572 +1
==========================================
- Hits 2778 2738 -40
- Misses 500 542 +42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/Swashbuckle.AspNetCore.SwaggerGen/SchemaGenerator/SchemaGenerator.cs
Outdated
Show resolved
Hide resolved
...Swashbuckle.AspNetCore.SwaggerGen.Test/SchemaGenerator/JsonSerializerSchemaGeneratorTests.cs
Show resolved
Hide resolved
…nerator.cs Co-authored-by: Martin Costello <[email protected]>
martincostello
merged commit 356c595
into
domaindrivendev:master
14 of 15 checks passed
This was referenced Jul 28, 2025
This was referenced Aug 6, 2025
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
timerknight/skills-secure-repository-supply-chain#17
Open
Open
Open
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
bledeamarius/skills-secure-repository-supply-chain#7
Open
Open
Open
[Dependabot | NuGet] Bump Swashbuckle.AspNetCore from 7.3.1 to 9.0.3
LightJack05/AnonKey-Backend#153
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
This Pull Request should hopefully address an issue where Arrays/Lists of Nullable types where not getting correctly marked as Nullable in the generated swagger.
Resolves #3284
Details on the issue fix or feature implementation
In GenerateSchema -> GenerateSchemaForType I added a check to see if the Array underlying type was nullable. If so, it would mark the corresponding section in the schema (in this case items) with nullable = true.