Skip to content

Drop .NET 6 #3183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 18, 2025
Merged

Drop .NET 6 #3183

merged 4 commits into from
Mar 18, 2025

Conversation

martincostello
Copy link
Collaborator

@martincostello martincostello commented Nov 27, 2024

Drop support for .NET 6.

Resolves #3087.

@martincostello martincostello added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code version-major A change suitable for release in a major version labels Nov 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (730b315) to head (d549578).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3183   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files          77       77           
  Lines        3224     3224           
  Branches      559      559           
=======================================
  Hits         2694     2694           
  Misses        530      530           
Flag Coverage Δ
Linux 83.56% <ø> (ø)
Windows 83.56% <ø> (ø)
macOS 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello added this to the v8.0.0 milestone Nov 27, 2024
@Saibamen
Copy link
Contributor

Saibamen commented Nov 28, 2024

Please remove all #if NET6_0_OR_GREATER and #if NET7_0_OR_GREATER.

And if these IF statements have ELSE, update check to #if NET8_0_OR_GREATER. <----- EDIT: Umm, no, this is Swashbuckle.AspNetCore, not NSwag :D - we are not supporting .NET Framework

image

@martincostello
Copy link
Collaborator Author

martincostello commented Nov 28, 2024

No, that's unnecessary code churn that makes no difference just changing the version numbers.

The elses may be removable in some cases, but only for projects that don't target netstandard2.0.

martincostello and others added 2 commits January 21, 2025 08:58
Drop support for .NET 6.
Resolves #3087.
Co-authored-by: Adam Stachowicz <[email protected]>
@martincostello martincostello mentioned this pull request Mar 5, 2025
12 tasks
This was referenced Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code version-major A change suitable for release in a major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for .NET 6
4 participants