Remove --serializeasv2

Remove deprecated `--serializeasv2` option.

Author: martincostello

src/Swashbuckle.AspNetCore.Cli/Program.cs

@@ -17,7 +17,6 @@ namespace Swashbuckle.AspNetCore.Cli;
 internal class Program
 {
     private const string OpenApiVersionOption = "--openapiversion";
-    private const string SerializeAsV2Flag = "--serializeasv2";
 
     public static int Main(string[] args)
     {
@@ -41,9 +40,6 @@ public static int Main(string[] args)
             c.Option(OpenApiVersionOption, "output Swagger in the specified version, defaults to 3.0");
             c.Option("--yaml", "exports swagger in a yaml format", true);
 
-            // TODO Remove this option in the major version that adds support for OpenAPI 3.1
-            c.Option(SerializeAsV2Flag, "output Swagger in the V2 format rather than V3 [deprecated]", true);
-
             c.OnRun((namedArgs) =>
             {
                 string subProcessCommandLine = PrepareCommandLine(args, namedArgs);
@@ -66,9 +62,6 @@ public static int Main(string[] args)
             c.Option(OpenApiVersionOption, "");
             c.Option("--yaml", "", true);
 
-            // TODO Remove this option in the major version that adds support for OpenAPI 3.1
-            c.Option(SerializeAsV2Flag, "", true);
-
             c.OnRun((namedArgs) =>
             {
                 SetupAndRetrieveSwaggerProviderAndOptions(namedArgs, out var swaggerProvider, out var swaggerOptions);
@@ -116,11 +109,6 @@ public static int Main(string[] args)
                         _ => throw new NotSupportedException($"The specified OpenAPI version \"{versionArg}\" is not supported."),
                     };
                 }
-                else if (namedArgs.ContainsKey(SerializeAsV2Flag))
-                {
-                    specVersion = OpenApiSpecVersion.OpenApi2_0;
-                    WriteSerializeAsV2DeprecationWarning();
-                }
 
                 if (swaggerDocumentSerializer != null)
                 {
@@ -328,20 +316,4 @@ private static bool TryGetCustomHost<THost>(
         host = (THost)factoryMethod.Invoke(null, null);
         return true;
     }
-
-    private static void WriteSerializeAsV2DeprecationWarning()
-    {
-        const string AppName = "Swashbuckle.AspNetCore.Cli";
-
-        string message = $"The {SerializeAsV2Flag} flag will be removed in a future version of {AppName}. Use the {OpenApiVersionOption} option instead.";
-
-        Console.WriteLine(message);
-
-        // See https://docs.github.com/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#setting-a-warning-message
-        // and https://docs.github.com/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables
-        if (Environment.GetEnvironmentVariable("GITHUB_ACTIONS") is "true")
-        {
-            Console.WriteLine($"::warning title={AppName}::{message}");
-        }
-    }
 }

test/Swashbuckle.AspNetCore.Cli.Test/ToolTests.cs

@@ -69,27 +69,6 @@ public static void Can_Generate_Swagger_Json_v2_OpenApiVersion()
         Assert.True(productsPath.TryGetProperty("post", out _));
     }
 
-    [Fact]
-    public static void Can_Generate_Swagger_Json_v2_SerializeAsV2()
-    {
-        using var document = RunToJsonCommand((outputPath) =>
-        [
-            "tofile",
-            "--output",
-            outputPath,
-            "--serializeasv2",
-            Path.Combine(Directory.GetCurrentDirectory(), "Basic.dll"),
-            "v1"
-        ]);
-
-        Assert.Equal("2.0", document.RootElement.GetProperty("swagger").GetString());
-
-        // verify one of the endpoints
-        var paths = document.RootElement.GetProperty("paths");
-        var productsPath = paths.GetProperty("/products");
-        Assert.True(productsPath.TryGetProperty("post", out _));
-    }
-
     [Fact]
     public static void Can_Generate_Swagger_Json_v3()
     {