cli-plugins/manager: IsNotFound: don't depend on causer interface #5794
Conversation
Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
added
status/2-code-review
kind/refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5794 +/- ##
==========================================
- Coverage 59.44% 59.17% -0.27%
==========================================
Files 347 353 +6
Lines 29394 29472 +78
==========================================
- Hits 17472 17440 -32
- Misses 10950 11059 +109
- Partials 972 973 +1 |
| err = e.Cause() | ||
| var e *pluginError | ||
| if errors.As(err, &e) { | ||
| err = e.Unwrap() |
There was a problem hiding this comment.
Would you be able to add more context to the commit on why this needs to change?
The error could also be wrapped multiple times before it's a notFound type. Are we sure we never wrap the error more than once?
Benehiko
left a comment
Benehiko
left a comment
There was a problem hiding this comment.
We can also get this one merged soon if you'd like. I don't have the full context yet though (see previous comment), but the change seems alright.
|
Oh! Sorry forgot about this one; I need to double-check if this could cause a change in behavior; considering that |
3 participants
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)