DEV: Disable the plugin by default (#1511)

…and preserve the current setting on existing sites

Author: CvX

config/settings.yml

@@ -1,6 +1,6 @@
 discourse_ai:
   discourse_ai_enabled:
-    default: true
+    default: false
     client: true
   ai_artifact_security:
     client: true

db/migrate/20250721192553_enable_ai_if_already_installed.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+class EnableAiIfAlreadyInstalled < ActiveRecord::Migration[7.2]
+  def up
+    installed_at = DB.query_single(<<~SQL)&.first
+      SELECT created_at FROM schema_migration_details WHERE version='20230224165056'
+    SQL
+
+    if installed_at && installed_at < 1.hour.ago
+      # The plugin was installed before we changed it to be disabled-by-default
+      # Therefore, if there is no existing database value, enable the plugin
+      execute <<~SQL
+        INSERT INTO site_settings(name, data_type, value, created_at, updated_at)
+        VALUES('discourse_ai_enabled', 5, 't', NOW(), NOW())
+        ON CONFLICT (name) DO NOTHING
+      SQL
+    end
+  end
+
+  def down
+    raise ActiveRecord::IrreversibleMigration
+  end
+end

spec/configuration/feature_spec.rb

@@ -10,6 +10,8 @@ def allow_configuring_setting(&block)
     DiscourseAi::Completions::Llm.with_prepared_responses(["OK"]) { block.call }
   end
 
+  before { enable_current_plugin }
+
   describe "#llm_model" do
     context "when persona is not found" do
       it "returns nil when persona_id is invalid" do

spec/configuration/llm_enumerator_spec.rb

@@ -8,6 +8,8 @@
     Fabricate(:automation, script: "llm_report", name: "some automation", enabled: true)
   end
 
+  before { enable_current_plugin }
+
   describe "#values_for_serialization" do
     it "returns an array for that can be used for serialization" do
       fake_model.destroy!

spec/configuration/llm_validator_spec.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 RSpec.describe DiscourseAi::Configuration::LlmValidator do
+  before { enable_current_plugin }
+
   describe "#valid_value?" do
     context "when the parent module is enabled and we try to reset the selected model" do
       before do

spec/configuration/spam_detection_validator_spec.rb

@@ -3,6 +3,8 @@
 RSpec.describe DiscourseAi::Configuration::SpamDetectionValidator do
   let(:validator) { described_class.new }
 
+  before { enable_current_plugin }
+
   it "always returns true if setting the value to false" do
     expect(validator.valid_value?("f")).to eq(true)
   end

spec/db/migrate/20241031041242_migrate_sentiment_classification_result_format_spec.rb

@@ -8,11 +8,14 @@
 RSpec.describe MigrateSentimentClassificationResultFormat do
   let(:connection) { ActiveRecord::Base.connection }
 
-  before { connection.execute(<<~SQL) }
+  before do
+    enable_current_plugin
+    connection.execute(<<~SQL)
       INSERT INTO classification_results (model_used, classification, created_at, updated_at) VALUES
         ('sentiment', '{"neutral": 65, "negative": 20, "positive": 14}', NOW(), NOW()),
         ('emotion', '{"sadness": 10, "surprise": 15, "fear": 5, "anger": 20, "joy": 30, "disgust": 8, "neutral": 10}', NOW(), NOW());
     SQL
+  end
 
   after { connection.execute("DELETE FROM classification_results") }
 
@@ -21,7 +24,7 @@
 
     it "migrates sentiment classifications correctly" do
       sentiment_result = connection.execute(<<~SQL).first
-        SELECT * FROM classification_results 
+        SELECT * FROM classification_results
         WHERE model_used = 'cardiffnlp/twitter-roberta-base-sentiment-latest';
       SQL
 
@@ -32,7 +35,7 @@
 
     it "migrates emotion classifications correctly" do
       emotion_result = connection.execute(<<~SQL).first
-        SELECT * FROM classification_results 
+        SELECT * FROM classification_results
         WHERE model_used = 'j-hartmann/emotion-english-distilroberta-base';
       SQL
 

spec/db/migrate/20250125162658_fix_broken_open_ai_embeddings_config_spec.rb

@@ -21,6 +21,8 @@ def configured_model_id
     ).first
   end
 
+  before { enable_current_plugin }
+
   describe "#up" do
     context "when embeddings are already configured" do
       fab!(:embedding_definition)

spec/db/migrate/20250127145305_clean_unused_embedding_search_indexes_spec.rb

@@ -8,6 +8,8 @@
 RSpec.describe CleanUnusedEmbeddingSearchIndexes do
   let(:connection) { ActiveRecord::Base.connection }
 
+  before { enable_current_plugin }
+
   describe "#up" do
     before do
       # Copied from 20241008054440_create_binary_indexes_for_embeddings

spec/jobs/regular/detect_translate_post_spec.rb

@@ -7,7 +7,7 @@
   let(:locales) { %w[en ja] }
 
   before do
-    SiteSetting.discourse_ai_enabled = true
+    enable_current_plugin
     Fabricate(:fake_model).tap do |fake_llm|
       SiteSetting.public_send("ai_translation_model=", "custom:#{fake_llm.id}")
     end