chore: upgrade to biome v2 (#101)

Author: JustinBeckwith

biome.json

@@ -1,11 +1,9 @@
 {
-	"$schema": "https://biomejs.dev/schemas/1.6.4/schema.json",
+	"$schema": "https://biomejs.dev/schemas/2.2.5/schema.json",
 	"files": {
-		"include": ["src/**/*.ts", "examples/*.js"]
-	},
-	"organizeImports": {
-		"enabled": true
+		"includes": ["**/src/**/*.ts", "**/examples/**/*.js"]
 	},
+	"assist": { "actions": { "source": { "organizeImports": "on" } } },
 	"linter": {
 		"enabled": true,
 		"rules": {

examples/express_app.js

@@ -28,7 +28,7 @@ app.post(
 app.post(
 	'/events',
 	verifyWebhookEventMiddleware(process.env.CLIENT_PUBLIC_KEY),
-	(req, res) => {
+	(req, _res) => {
 		console.log('📨 Event Received!');
 		console.log(
 			util.inspect(req.body, { showHidden: false, colors: true, depth: null }),
@@ -37,7 +37,7 @@ app.post(
 );
 
 // Simple health check, to also make it easy to check if the app is up and running
-app.get('/health', (req, res) => {
+app.get('/health', (_req, res) => {
 	res.send('ok');
 });
 

package-lock.json

@@ -34,7 +34,7 @@
     "discord-interactions": "^4.3.0"
   },
   "devDependencies": {
-    "@biomejs/biome": "^1.7.3",
+    "@biomejs/biome": "^2.2.5",
     "@types/express": "^4.17.9",
     "@types/jest": "^29.0.0",
     "@types/node": "^22.0.0",

package.json

@@ -77,7 +77,7 @@ export async function signRequestWithKeyPair(
 	body: string,
 	privateKey: CryptoKey,
 ) {
-	const timestamp = String(Math.round(new Date().getTime() / 1000));
+	const timestamp = String(Math.round(Date.now() / 1000));
 	const signature = await subtleCrypto.sign(
 		{
 			name: 'ed25519',

src/__tests__/utils/SharedTestUtils.ts

@@ -128,7 +128,7 @@ describe('verify key method', () => {
 		const isValid = await verifyKey(
 			signedRequest.body,
 			signedRequest.signature,
-			String(Math.round(new Date().getTime() / 1000) - 10000),
+			String(Math.round(Date.now() / 1000) - 10000),
 			validKeyPair.publicKey,
 		);
 		expect(isValid).toBe(false);

src/__tests__/verifyKey.ts

@@ -1,12 +1,14 @@
 import type * as http from 'node:http';
 import type { AddressInfo } from 'node:net';
 import type { Request, Response } from 'express';
+import express from 'express';
 import {
 	InteractionResponseFlags,
 	InteractionResponseType,
 	InteractionType,
 	verifyKeyMiddleware,
 } from '../index';
+import { subtleCrypto } from '../util';
 import {
 	applicationCommandRequestBody,
 	autocompleteRequestBody,
@@ -17,9 +19,6 @@ import {
 	signRequestWithKeyPair,
 } from './utils/SharedTestUtils';
 
-import express from 'express';
-import { subtleCrypto } from '../util';
-
 const expressApp = express();
 
 const exampleApplicationCommandResponse = {
@@ -246,9 +245,7 @@ describe('verify key middleware', () => {
 			exampleInteractionsUrl,
 			{
 				'x-signature-ed25519': signedRequest.signature,
-				'x-signature-timestamp': String(
-					Math.round(new Date().getTime() / 1000) - 10000,
-				),
+				'x-signature-timestamp': String(Math.round(Date.now() / 1000) - 10000),
 				'content-type': 'application/json',
 			},
 			signedRequest.body,

src/__tests__/verifyKeyMiddleware.ts

@@ -1,17 +1,16 @@
 import type * as http from 'node:http';
 import type { AddressInfo } from 'node:net';
 import type { Request, Response } from 'express';
+import express from 'express';
 import { verifyWebhookEventMiddleware } from '../index';
+import { subtleCrypto } from '../util';
 import { WebhookEventType, WebhookType } from '../webhooks';
 import {
 	generateKeyPair,
 	sendExampleRequest,
 	signRequestWithKeyPair,
 } from './utils/SharedTestUtils';
 
-import express from 'express';
-import { subtleCrypto } from '../util';
-
 const expressApp = express();
 
 // Example webhook ping request body
@@ -63,7 +62,7 @@ describe('verify webhook event middleware', () => {
 				next();
 			},
 			verifyWebhookEventMiddleware(rawPublicKey),
-			(req: Request, res: Response) => {
+			(_req: Request, res: Response) => {
 				// This handler will be reached but the response has already been sent
 				// by the middleware with 204 status
 				if (!res.headersSent) {
@@ -183,9 +182,7 @@ describe('verify webhook event middleware', () => {
 			exampleWebhookUrl,
 			{
 				'x-signature-ed25519': signedRequest.signature,
-				'x-signature-timestamp': String(
-					Math.round(new Date().getTime() / 1000) - 10000,
-				),
+				'x-signature-timestamp': String(Math.round(Date.now() / 1000) - 10000),
 				'content-type': 'application/json',
 			},
 			signedRequest.body,
@@ -266,7 +263,7 @@ describe('verify webhook event middleware', () => {
 		testApp.post(
 			'/webhook-test',
 			verifyWebhookEventMiddleware(rawPublicKey),
-			(req: Request, res: Response) => {
+			(_req: Request, res: Response) => {
 				// This handler tries to send a response after middleware already sent one
 				try {
 					res.json({ shouldFail: true });

src/__tests__/verifyWebhookEventMiddleware.ts

@@ -211,7 +211,7 @@ export type EmojiInfo = {
 	name: string | undefined;
 	id: string | undefined;
 	// Should define the user object in future
-	// biome-ignore lint/suspicious/noExplicitAny: <explanation>
+	// biome-ignore lint/suspicious/noExplicitAny: user object not fully typed yet
 	user?: { [key: string]: any };
 	roles?: string[];
 	require_colons?: boolean;

src/components.ts

@@ -129,7 +129,7 @@ export async function verifyKey(
 			message,
 		);
 		return isValid;
-	} catch (ex) {
+	} catch (_ex) {
 		return false;
 	}
 }