Skip to content

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Nov 26, 2023

Changed:

  • Remove redundant tests in GroovyGradleExtensionTest, and let it extend GroovyExtensionTest.
  • Remove redundant tests in KotlinGradleExtensionTest, and let it extend KotlinExtensionTest.
  • Bump Kotlin plugins for Java 21 tests in the future.

Follow up:

@Goooler Goooler force-pushed the bump-kt-plugin-in-tests branch from 8d32b45 to 4775485 Compare November 26, 2023 09:34
We can't use the latest version, due to the Gradle matrix limit in tests.
setFile("build.gradle").toLines(
"plugins {",
" id 'org.jetbrains.kotlin.jvm' version '1.5.31'",
" id 'org.jetbrains.kotlin.jvm' version '1.6.21'",
Copy link
Member Author

@Goooler Goooler Nov 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump this for #1907, can't use newer Kotlin versions due to the limit of Gradle matrix.

@nedtwigg nedtwigg merged commit c4f8a88 into diffplug:main Nov 27, 2023
@Goooler Goooler deleted the bump-kt-plugin-in-tests branch November 27, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants