Skip to content

Commit a37e3df

Browse files
ns not found in case ips is being injected in cluster (#4844)
1 parent 3467863 commit a37e3df

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

pkg/dockerRegistry/DockerRegistryIpsConfigService.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,15 @@ import (
2323
repository3 "github.com/devtron-labs/devtron/internal/sql/repository"
2424
"github.com/devtron-labs/devtron/internal/sql/repository/dockerRegistry"
2525
"github.com/devtron-labs/devtron/internal/sql/repository/pipelineConfig"
26+
util2 "github.com/devtron-labs/devtron/internal/util"
2627
"github.com/devtron-labs/devtron/pkg/cluster"
2728
repository2 "github.com/devtron-labs/devtron/pkg/cluster/repository"
2829
"github.com/go-pg/pg"
2930
"go.uber.org/zap"
3031
v1 "k8s.io/api/core/v1"
3132
k8sErrors "k8s.io/apimachinery/pkg/api/errors"
3233
"net/http"
34+
"strconv"
3335
"strings"
3436
)
3537

@@ -274,6 +276,10 @@ func (impl DockerRegistryIpsConfigServiceImpl) createOrUpdateDockerRegistryImage
274276
ipsData := BuildIpsData(registryURL, username, password, email)
275277
_, err = impl.k8sUtil.CreateSecret(namespace, ipsData, ipsName, v1.SecretTypeDockerConfigJson, k8sClient, nil, nil)
276278
if err != nil {
279+
if statusError, ok = err.(*k8sErrors.StatusError); ok {
280+
errorCode := int(statusError.ErrStatus.Code)
281+
err = &util2.ApiError{Code: strconv.Itoa(errorCode), HttpStatusCode: errorCode, UserMessage: statusError.Error(), InternalMessage: statusError.Error()}
282+
}
277283
impl.logger.Errorw("error in creating secret", "clusterId", clusterId, "namespace", namespace, "ipsName", ipsName, "error", err)
278284
return err
279285
}

0 commit comments

Comments
 (0)