Revert find list shim, too many side effects.

Author: dereuromark

src/Model/Table/Table.php

@@ -10,7 +10,6 @@
 use Cake\ORM\Table as CoreTable;
 use Cake\Utility\Inflector;
 use Cake\Validation\Validator;
-use Closure;
 use Exception;
 use InvalidArgumentException;
 
@@ -314,26 +313,6 @@ public function fieldByConditions(string $name, array $conditions = [], array $c
 		return $result->get($name);
 	}
 
-	/**
-	 * @param \Cake\ORM\Query\SelectQuery $query
-	 * @param \Closure|array|string|null $keyField
-	 * @param \Closure|array|string|null $valueField
-	 * @param \Closure|array|string|null $groupField
-	 * @param string $valueSeparator
-	 * @return \Cake\ORM\Query\SelectQuery
-	 */
-	public function findList(SelectQuery $query, array|string|Closure|null $keyField = null, array|string|Closure|null $valueField = null, array|string|Closure|null $groupField = null, string $valueSeparator = ' '): SelectQuery {
-		$fields = $query->clause('select');
-		if ($keyField === null && $valueField === null && count($fields) === 2) {
-			$keyField = array_shift($fields);
-			$valueField = array_shift($fields);
-		} elseif ($keyField === null && $valueField === null && count($fields) === 1) {
-			$valueField = array_shift($fields);
-		}
-
-		return parent::findList($query, $keyField, $valueField, $groupField, $valueSeparator);
-	}
-
 	/**
 	 * Sets the default ordering as 2.x shim.
 	 *

tests/TestCase/Model/Table/TableTest.php

@@ -413,30 +413,4 @@ public function testSaveStrict(): void {
 		$this->Wheels->save($wheel, ['strict' => true]);
 	}
 
-	/**
-	 * @return void
-	 */
-	public function testFindList(): void {
-		$result = $this->Posts->find('list', fields: ['title', 'body'])->toArray();
-		$expected = [
-			'First Post' => 'First Post Body',
-			'Second Post' => 'Second Post Body',
-			'Third Post' => 'Third Post Body',
-		];
-		$this->assertEquals($expected, $result);
-	}
-
-	/**
-	 * @return void
-	 */
-	public function testFindListSingleField(): void {
-		$result = $this->Posts->find('list', fields: ['id'])->toArray();
-		$expected = [
-			1 => 1,
-			2 => 2,
-			3 => 3,
-		];
-		$this->assertEquals($expected, $result);
-	}
-
 }