Skip to content

Commit a2f07c5

Browse files
dequejenndequejenn
authored
chore: RC v4.9.1 (#1065)
## [4.9.1](v4.9.0...v4.9.1) (2024-05-15) ### Bug Fixes * **playwright:** skip unloaded iframes ([#1060](#1060)) ([d30dae4](d30dae4)) * Update axe-core to v4.9.1 ([#1055](#1055)) ([8644fbd](8644fbd)) No qa needed
2 parents b24b979 + e694f41 commit a2f07c5

File tree

22 files changed

+4900
-8074
lines changed

22 files changed

+4900
-8074
lines changed

‎.github/workflows/sync-master-develop.yml‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ jobs:
1212
steps:
1313
- uses: dequelabs/action-sync-branches@v1
1414
with:
15-
github-token: ${{ secrets.GITHUB_TOKEN }}
15+
github-token: ${{ secrets.PAT }}
1616
pr-title: 'chore: merge master into develop'
17-
pr-reviewers: michael-siek,stephenmathieson
17+
pr-team-reviewers: axe-api-team
1818
pr-labels: chore
19-
pr-template: .github/PULL_REQUEST_TEMPLATE.md

‎CHANGELOG.md‎

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3,43 +3,29 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6-
## [4.9.1](https://github.com/dequelabs/axe-core-npm/compare/v4.9.0...v4.9.1) (2024-05-10)
7-
6+
## [4.9.1](https://github.com/dequelabs/axe-core-npm/compare/v4.9.0...v4.9.1) (2024-05-15)
87

98
### Bug Fixes
109

11-
* Update axe-core to v4.9.1 ([#1055](https://github.com/dequelabs/axe-core-npm/issues/1055)) ([8644fbd](https://github.com/dequelabs/axe-core-npm/commit/8644fbd2d2b407c68b5ff3bd7b8368c6c173e355))
12-
13-
14-
10+
- **playwright:** skip unloaded iframes ([#1060](https://github.com/dequelabs/axe-core-npm/issues/1060)) ([d30dae4](https://github.com/dequelabs/axe-core-npm/commit/d30dae4a6fede397bc49b5171c4cb4c43e545b53))
1511

12+
- Update axe-core to v4.9.1 ([#1055](https://github.com/dequelabs/axe-core-npm/issues/1055)) ([8644fbd](https://github.com/dequelabs/axe-core-npm/commit/8644fbd2d2b407c68b5ff3bd7b8368c6c173e355))
1613

1714
# [4.9.0](https://github.com/dequelabs/axe-core-npm/compare/v4.8.5...v4.9.0) (2024-04-01)
1815

19-
2016
### Bug Fixes
2117

22-
* get correct new window handle with Selenium 3 workaround ([#1031](https://github.com/dequelabs/axe-core-npm/issues/1031)) ([b72c735](https://github.com/dequelabs/axe-core-npm/commit/b72c73571c12c81c2ef3dc3ebe89e15769f0942b)), closes [#1027](https://github.com/dequelabs/axe-core-npm/issues/1027) [/github.com/dequelabs/axe-core-maven-html/blob/ad58b26a8d0e2f1afed33b2c5cbca22b54644b99/selenium/src/main/java/com/deque/html/axecore/extensions/WebDriverExtensions.java#L126](https://github.com//github.com/dequelabs/axe-core-maven-html/blob/ad58b26a8d0e2f1afed33b2c5cbca22b54644b99/selenium/src/main/java/com/deque/html/axecore/extensions/WebDriverExtensions.java/issues/L126) [#936](https://github.com/dequelabs/axe-core-npm/issues/936)
23-
18+
- get correct new window handle with Selenium 3 workaround ([#1031](https://github.com/dequelabs/axe-core-npm/issues/1031)) ([b72c735](https://github.com/dequelabs/axe-core-npm/commit/b72c73571c12c81c2ef3dc3ebe89e15769f0942b)), closes [#1027](https://github.com/dequelabs/axe-core-npm/issues/1027) [/github.com/dequelabs/axe-core-maven-html/blob/ad58b26a8d0e2f1afed33b2c5cbca22b54644b99/selenium/src/main/java/com/deque/html/axecore/extensions/WebDriverExtensions.java#L126](https://github.com//github.com/dequelabs/axe-core-maven-html/blob/ad58b26a8d0e2f1afed33b2c5cbca22b54644b99/selenium/src/main/java/com/deque/html/axecore/extensions/WebDriverExtensions.java/issues/L126) [#936](https://github.com/dequelabs/axe-core-npm/issues/936)
2419

2520
### Features
2621

27-
* Update axe-core to v4.9.0 ([#1028](https://github.com/dequelabs/axe-core-npm/issues/1028)) ([7e152b6](https://github.com/dequelabs/axe-core-npm/commit/7e152b65ff30b9e1cb26c3b0564457b32a0d35b2))
28-
29-
30-
31-
22+
- Update axe-core to v4.9.0 ([#1028](https://github.com/dequelabs/axe-core-npm/issues/1028)) ([7e152b6](https://github.com/dequelabs/axe-core-npm/commit/7e152b65ff30b9e1cb26c3b0564457b32a0d35b2))
3223

3324
## [4.8.5](https://github.com/dequelabs/axe-core-npm/compare/v4.8.4...v4.8.5) (2024-02-08)
3425

35-
3626
### Bug Fixes
3727

38-
* Update axe-core to v4.8.4 ([#1008](https://github.com/dequelabs/axe-core-npm/issues/1008)) ([d54f145](https://github.com/dequelabs/axe-core-npm/commit/d54f145a4078c4730a850e694c9eb77297c23a35))
39-
40-
41-
42-
28+
- Update axe-core to v4.8.4 ([#1008](https://github.com/dequelabs/axe-core-npm/issues/1008)) ([d54f145](https://github.com/dequelabs/axe-core-npm/commit/d54f145a4078c4730a850e694c9eb77297c23a35))
4329

4430
## [4.8.4](https://github.com/dequelabs/axe-core-npm/compare/v4.8.3...v4.8.4) (2024-01-23)
4531

‎package-lock.json‎

Lines changed: 4844 additions & 8011 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎packages/cli/CHANGELOG.md‎

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,31 +7,17 @@ See [Conventional Commits](https://conventionalcommits.org) for commit guideline
77

88
**Note:** Version bump only for package @axe-core/cli
99

10-
11-
12-
13-
1410
# [4.9.0](https://github.com/dequelabs/axe-core-npm/compare/v4.8.5...v4.9.0) (2024-04-01)
1511

16-
1712
### Features
1813

19-
* Update axe-core to v4.9.0 ([#1028](https://github.com/dequelabs/axe-core-npm/issues/1028)) ([7e152b6](https://github.com/dequelabs/axe-core-npm/commit/7e152b65ff30b9e1cb26c3b0564457b32a0d35b2))
20-
21-
22-
23-
14+
- Update axe-core to v4.9.0 ([#1028](https://github.com/dequelabs/axe-core-npm/issues/1028)) ([7e152b6](https://github.com/dequelabs/axe-core-npm/commit/7e152b65ff30b9e1cb26c3b0564457b32a0d35b2))
2415

2516
## [4.8.5](https://github.com/dequelabs/axe-core-npm/compare/v4.8.4...v4.8.5) (2024-02-08)
2617

27-
2818
### Bug Fixes
2919

30-
* Update axe-core to v4.8.4 ([#1008](https://github.com/dequelabs/axe-core-npm/issues/1008)) ([d54f145](https://github.com/dequelabs/axe-core-npm/commit/d54f145a4078c4730a850e694c9eb77297c23a35))
31-
32-
33-
34-
20+
- Update axe-core to v4.8.4 ([#1008](https://github.com/dequelabs/axe-core-npm/issues/1008)) ([d54f145](https://github.com/dequelabs/axe-core-npm/commit/d54f145a4078c4730a850e694c9eb77297c23a35))
3521

3622
## [4.8.4](https://github.com/dequelabs/axe-core-npm/compare/v4.8.3...v4.8.4) (2024-01-23)
3723

‎packages/cli/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,11 @@
4848
],
4949
"dependencies": {
5050
"@axe-core/webdriverjs": "^4.9.1",
51-
"axe-core": "~4.9.0",
51+
"axe-core": "~4.9.1",
5252
"chromedriver": "latest",
5353
"colors": "^1.4.0",
5454
"commander": "^9.4.1",
55-
"selenium-webdriver": "~4.17.0"
55+
"selenium-webdriver": "~4.20.0"
5656
},
5757
"devDependencies": {
5858
"@types/chai": "^4.3.3",

‎packages/cli/src/lib/webdriver.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const startDriver = async (
1717

1818
let options = new chrome.Options();
1919
// selenium-webdriver < 4.17.0
20-
if (typeof options.headless === 'function') {
20+
if ('headless' in options && typeof options.headless === 'function') {
2121
options.headless();
2222
}
2323
// selenium-webdriver >= 4.17.0

‎packages/playwright/CHANGELOG.md‎

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,12 @@
33
All notable changes to this project will be documented in this file.
44
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
55

6-
## [4.9.1](https://github.com/dequelabs/axe-core-npm/compare/v4.9.0...v4.9.1) (2024-05-10)
6+
## [4.9.1](https://github.com/dequelabs/axe-core-npm/compare/v4.9.0...v4.9.1) (2024-05-15)
77

8-
**Note:** Version bump only for package @axe-core/playwright
8+
9+
### Bug Fixes
10+
11+
* **playwright:** skip unloaded iframes ([#1060](https://github.com/dequelabs/axe-core-npm/issues/1060)) ([d30dae4](https://github.com/dequelabs/axe-core-npm/commit/d30dae4a6fede397bc49b5171c4cb4c43e545b53))
912

1013

1114

‎packages/playwright/package.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,10 @@
5151
"prepare": "npx playwright install && npm run build"
5252
},
5353
"dependencies": {
54-
"axe-core": "~4.9.0"
54+
"axe-core": "~4.9.1"
5555
},
5656
"devDependencies": {
57-
"@playwright/test": "^1.34.3",
57+
"@playwright/test": "^1.44.0",
5858
"@types/chai": "^4.3.3",
5959
"@types/express": "^4.17.14",
6060
"@types/mocha": "^10.0.0",

‎packages/playwright/src/index.ts‎

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -183,10 +183,24 @@ export default class AxeBuilder {
183183
* @returns Promise<void>
184184
*/
185185

186-
private async inject(frames: Frame[]): Promise<void> {
186+
private async inject(frames: Frame[], shouldThrow?: boolean): Promise<void> {
187187
for (const iframe of frames) {
188-
await iframe.evaluate(await this.script());
189-
await iframe.evaluate(await this.axeConfigure());
188+
const race = new Promise((_, reject) => {
189+
setTimeout(() => {
190+
reject(new Error('Script Timeout'));
191+
}, 1000);
192+
});
193+
const evaluate = iframe.evaluate(this.script());
194+
195+
try {
196+
await Promise.race([evaluate, race]);
197+
await iframe.evaluate(await this.axeConfigure());
198+
} catch (err) {
199+
// in legacy mode we don't want to throw the error we just want to skip injecting into the frame
200+
if (shouldThrow) {
201+
throw err;
202+
}
203+
}
190204
}
191205
}
192206

@@ -256,7 +270,7 @@ export default class AxeBuilder {
256270
iframeHandle.asElement() as ElementHandle<Element>;
257271
const childFrame = await iframeElement.contentFrame();
258272
if (childFrame) {
259-
await this.inject([childFrame]);
273+
await this.inject([childFrame], true);
260274
childResults = await this.runPartialRecursive(
261275
childFrame,
262276
frameContext

‎packages/playwright/test/axe-playwright.spec.ts‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -447,7 +447,12 @@ describe('@axe-core/playwright', () => {
447447
.analyze();
448448

449449
assert.equal(res?.status(), 200);
450-
assert.lengthOf(results.incomplete, 0);
450+
assert.equal(results.incomplete[0].id, 'frame-tested');
451+
assert.lengthOf(results.incomplete[0].nodes, 1);
452+
assert.deepEqual(results.incomplete[0].nodes[0].target, [
453+
'#ifr-lazy',
454+
'#lazy-iframe'
455+
]);
451456
assert.equal(results.violations[0].id, 'label');
452457
assert.lengthOf(results.violations[0].nodes, 1);
453458
assert.deepEqual(results.violations[0].nodes[0].target, [

0 commit comments

Comments
 (0)