Skip to content

Commit 0daba98

Browse files
authored
fix(webdriverjs): use new headless argument to fix [email protected] breaking release (#992)
* fix(webdriverjs): use new headless argument to fix [email protected] breaking release * fix webdriverjs tests to use addArguments too * fix cli test * use --headless instead of --headless=new * use headless to reduce change diff
1 parent 2220400 commit 0daba98

File tree

4 files changed

+19
-10
lines changed

4 files changed

+19
-10
lines changed

package-lock.json

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
"chromedriver": "latest",
5353
"colors": "^1.4.0",
5454
"commander": "^9.4.1",
55-
"selenium-webdriver": "^4.8.1"
55+
"selenium-webdriver": "~4.17.0"
5656
},
5757
"devDependencies": {
5858
"@types/chai": "^4.3.3",

packages/cli/src/lib/webdriver.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,16 @@ const startDriver = async (
1515
config.chromedriverPath || chromedriver.path
1616
);
1717

18-
let options = new chrome.Options().headless();
18+
let options = new chrome.Options();
19+
// selenium-webdriver < 4.17.0
20+
if (typeof options.headless === 'function') {
21+
options.headless();
22+
}
23+
// selenium-webdriver >= 4.17.0
24+
else {
25+
options.addArguments('headless');
26+
}
27+
1928
if (config.chromeOptions?.length) {
2029
options = config.chromeOptions.reduce(function (options, arg) {
2130
return options.addArguments(arg);

packages/webdriverjs/test/test-utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import chrome from 'selenium-webdriver/chrome';
55
export const Webdriver = (): WebDriver => {
66
const builder = new Builder()
77
.forBrowser('chrome')
8-
.setChromeOptions(new chrome.Options().headless())
8+
.setChromeOptions(new chrome.Options().addArguments('headless'))
99
.setChromeService(
1010
new chrome.ServiceBuilder(
1111
process.env.CHROMEDRIVER_PATH || chromedriver.path

0 commit comments

Comments
 (0)