feat: add DENO_JOBS env variable and deprecate numeric value for --jobs

Author: mrkldshv

cli/args/flags.rs

@@ -480,6 +480,10 @@ static ENV_VARIABLES_HELP: &str = r#"ENVIRONMENT VARIABLES:
     DENO_NO_PROMPT       Set to disable permission prompts on access
                          (alternative to passing --no-prompt on invocation)
     DENO_WEBGPU_TRACE    Directory to use for wgpu traces
+    DENO_JOBS            Number of parallel workers used for test subcommand. 
+                         Defaults to number of available CPUs when used with
+                         --jobs flag and no value is provided. 
+                         Defaults to 1 when --jobs flag is not used.
     HTTP_PROXY           Proxy address for HTTP requests
                          (module downloads, fetch)
     HTTPS_PROXY          Proxy address for HTTPS requests
@@ -1548,9 +1552,10 @@ fn test_subcommand<'a>() -> Command<'a> {
       Arg::new("jobs")
         .short('j')
         .long("jobs")
-        .help("Number of parallel workers, defaults to # of CPUs when no value is provided. Defaults to 1 when the option is not present.")
+        .help("Number of parallel workers, defaults to number of available CPUs when no value is provided. Defaults to 1 when the option is not present.")
         .min_values(0)
         .max_values(1)
+        .require_equals(true)
         .takes_value(true)
         .validator(|val: &str| match val.parse::<NonZeroUsize>() {
           Ok(_) => Ok(()),
@@ -2665,7 +2670,15 @@ fn test_parse(flags: &mut Flags, matches: &clap::ArgMatches) {
 
   let concurrent_jobs = if matches.is_present("jobs") {
     if let Some(value) = matches.value_of("jobs") {
+      println!(
+          "{}",
+          crate::colors::yellow("Warning: --jobs flag with numeric value is deprecated. Use 'DENO_JOBS' environment variable with --jobs flag instead."),
+        );
       value.parse().unwrap()
+    } else if let Ok(value) = env::var("DENO_JOBS") {
+      value
+        .parse::<NonZeroUsize>()
+        .unwrap_or(NonZeroUsize::new(1).unwrap())
     } else {
       std::thread::available_parallelism()
         .unwrap_or(NonZeroUsize::new(1).unwrap())

cli/tests/integration/test_tests.rs

@@ -62,6 +62,32 @@ itest!(collect {
   output: "test/collect.out",
 });
 
+itest!(jobs_flag {
+  args: "test test/short-pass.ts --jobs",
+  exit_code: 0,
+  output: "test/short-pass.out",
+});
+
+itest!(jobs_flag_with_numeric_value {
+  args: "test test/short-pass.ts --jobs=2",
+  exit_code: 0,
+  output: "test/short-pass-jobs-flag-with-numeric-value.out",
+});
+
+itest!(jobs_flag_with_env_variable {
+  args: "test test/short-pass.ts --jobs",
+  envs: vec![("DENO_JOBS".to_owned(), "2".to_owned())],
+  exit_code: 0,
+  output: "test/short-pass.out",
+});
+
+itest!(jobs_flag_with_numeric_value_and_env_var {
+  args: "test test/short-pass.ts --jobs=2",
+  envs: vec![("DENO_JOBS".to_owned(), "3".to_owned())],
+  exit_code: 0,
+  output: "test/short-pass-jobs-flag-with-numeric-value.out",
+});
+
 itest!(load_unload {
   args: "test test/load_unload.ts",
   exit_code: 0,

cli/tests/testdata/test/pass-jobs-flag.out

@@ -0,0 +1,24 @@
+Warning: --jobs flag is deprecated. Use 'DENO_JOBS' environment variable instead.
+Check [WILDCARD]/test/pass.ts
+running 10 tests from ./test/pass.ts
+test 0 ... ok ([WILDCARD])
+test 1 ... ok ([WILDCARD])
+test 2 ... ok ([WILDCARD])
+test 3 ... ok ([WILDCARD])
+test 4 ... ok ([WILDCARD])
+test 5 ... ok ([WILDCARD])
+test 6 ... ok ([WILDCARD])
+test 7 ... ok ([WILDCARD])
+test 8 ...
+------- output -------
+console.log
+----- output end -----
+test 8 ... ok ([WILDCARD])
+test 9 ...
+------- output -------
+console.error
+----- output end -----
+test 9 ... ok ([WILDCARD])
+
+ok | 10 passed | 0 failed ([WILDCARD])
+

cli/tests/testdata/test/short-pass-jobs-flag-with-numeric-value.out

@@ -0,0 +1,7 @@
+Warning: --jobs flag with numeric value is deprecated. Use 'DENO_JOBS' environment variable with --jobs flag instead.
+Check [WILDCARD]/test/short-pass.ts
+running 1 test from ./test/short-pass.ts
+test ... ok ([WILDCARD])
+
+ok | 1 passed | 0 failed ([WILDCARD])
+

cli/tests/testdata/test/short-pass.out

@@ -0,0 +1,6 @@
+Check [WILDCARD]/test/short-pass.ts
+running 1 test from ./test/short-pass.ts
+test ... ok ([WILDCARD])
+
+ok | 1 passed | 0 failed ([WILDCARD])
+

cli/tests/testdata/test/short-pass.ts

@@ -0,0 +1 @@
+Deno.test("test", () => {});