review

Author: devsnek

cli/module_loader.rs

@@ -63,7 +63,7 @@ use deno_graph::Module;
 use deno_graph::ModuleGraph;
 use deno_graph::Resolution;
 use deno_runtime::code_cache;
-use deno_runtime::deno_node::get_host_defined_options;
+use deno_runtime::deno_node::create_host_defined_options;
 use deno_runtime::deno_permissions::PermissionsContainer;
 use deno_semver::npm::NpmPackageReqReference;
 use node_resolver::NodeResolutionMode;
@@ -732,7 +732,7 @@ impl<TGraphContainer: ModuleGraphContainer> ModuleLoader
   ) -> Option<deno_core::v8::Local<'s, deno_core::v8::Data>> {
     let name = deno_core::ModuleSpecifier::parse(name).ok()?;
     if self.0.shared.node_resolver.in_npm_package(&name) {
-      Some(get_host_defined_options(scope))
+      Some(create_host_defined_options(scope))
     } else {
       None
     }

cli/standalone/mod.rs

@@ -25,7 +25,7 @@ use deno_core::ResolutionKind;
 use deno_npm::npm_rc::ResolvedNpmRc;
 use deno_package_json::PackageJsonDepValue;
 use deno_runtime::deno_fs;
-use deno_runtime::deno_node::get_host_defined_options;
+use deno_runtime::deno_node::create_host_defined_options;
 use deno_runtime::deno_node::NodeResolver;
 use deno_runtime::deno_permissions::Permissions;
 use deno_runtime::deno_permissions::PermissionsContainer;
@@ -275,7 +275,7 @@ impl ModuleLoader for EmbeddedModuleLoader {
   ) -> Option<deno_core::v8::Local<'s, deno_core::v8::Data>> {
     let name = deno_core::ModuleSpecifier::parse(name).ok()?;
     if self.shared.node_resolver.in_npm_package(&name) {
-      Some(get_host_defined_options(scope))
+      Some(create_host_defined_options(scope))
     } else {
       None
     }

ext/node/lib.rs

@@ -843,7 +843,7 @@ impl<'a> deno_package_json::fs::DenoPkgJsonFs for DenoPkgJsonFsAdapter<'a> {
   }
 }
 
-pub fn get_host_defined_options<'s>(
+pub fn create_host_defined_options<'s>(
   scope: &mut v8::HandleScope<'s>,
 ) -> v8::Local<'s, v8::Data> {
   let host_defined_options = v8::PrimitiveArray::new(scope, 1);

ext/node/ops/vm_internal.rs

@@ -1,6 +1,6 @@
 // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
 
-use crate::get_host_defined_options;
+use crate::create_host_defined_options;
 use deno_core::error::type_error;
 use deno_core::error::AnyError;
 use deno_core::v8;
@@ -21,7 +21,7 @@ impl ContextifyScript {
     source_str: v8::Local<v8::String>,
   ) -> Result<Self, AnyError> {
     let resource_name = v8::undefined(scope);
-    let host_defined_options = get_host_defined_options(scope);
+    let host_defined_options = create_host_defined_options(scope);
     let origin = v8::ScriptOrigin::new(
       scope,
       resource_name.into(),

ext/node/polyfills/01_require.js

@@ -1004,7 +1004,7 @@ Module.prototype._compile = function (content, filename, format) {
   const compiledWrapper = wrapSafe(filename, content, this, format);
 
   if (format === "module") {
-    // TODO: implement require esm
+    // TODO(https://github.com/denoland/deno/issues/24822): implement require esm
     throw createRequireEsmError(
       filename,
       moduleParentCache.get(module)?.filename,
@@ -1070,7 +1070,7 @@ Module._extensions[".js"] = function (module, filename) {
   if (StringPrototypeEndsWith(filename, ".js")) {
     const pkg = op_require_read_closest_package_json(filename);
     if (pkg?.typ === "module") {
-      // TODO: implement require esm
+      // TODO(https://github.com/denoland/deno/issues/24822): implement require esm
       format = "module";
       throw createRequireEsmError(
         filename,

ext/node_resolver/sync.rs

@@ -15,4 +15,9 @@ mod inner {
 #[cfg(not(feature = "sync"))]
 mod inner {
   pub use std::rc::Rc as MaybeArc;
+
+  pub trait MaybeSync {}
+  impl<T> MaybeSync for T where T: ?Sized {}
+  pub trait MaybeSend {}
+  impl<T> MaybeSend for T where T: ?Sized {}
 }