Skip to content

Commit 533d31b

Browse files
fix: node:inspector not being registered (#25007)
For some reason we didn't register the `node:inspector` module, which lead to a panic when trying to import it. This PR registers it. Related: #25004
1 parent 3b4cbc1 commit 533d31b

File tree

7 files changed

+13
-2
lines changed

7 files changed

+13
-2
lines changed

ext/node/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -483,7 +483,6 @@ deno_core::extension!(deno_node,
483483
"_zlib_binding.mjs",
484484
"_zlib.mjs",
485485
"assertion_error.ts",
486-
"inspector.ts",
487486
"internal_binding/_libuv_winerror.ts",
488487
"internal_binding/_listen.ts",
489488
"internal_binding/_node.ts",
@@ -616,6 +615,7 @@ deno_core::extension!(deno_node,
616615
"node:http" = "http.ts",
617616
"node:http2" = "http2.ts",
618617
"node:https" = "https.ts",
618+
"node:inspector" = "inspector.ts",
619619
"node:module" = "01_require.js",
620620
"node:net" = "net.ts",
621621
"node:os" = "os.ts",

ext/node/polyfill.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ generate_builtin_node_module_lists! {
4545
"http",
4646
"http2",
4747
"https",
48+
"inspector",
4849
"module",
4950
"net",
5051
"os",

ext/node/polyfills/01_require.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ import fsPromises from "node:fs/promises";
9292
import http from "node:http";
9393
import http2 from "node:http2";
9494
import https from "node:https";
95-
import inspector from "ext:deno_node/inspector.ts";
95+
import inspector from "node:inspector";
9696
import internalCp from "ext:deno_node/internal/child_process.ts";
9797
import internalCryptoCertificate from "ext:deno_node/internal/crypto/certificate.ts";
9898
import internalCryptoCipher from "ext:deno_node/internal/crypto/cipher.ts";

tests/integration/lsp_tests.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7548,6 +7548,7 @@ fn lsp_completions_node_specifier() {
75487548
"node:http",
75497549
"node:http2",
75507550
"node:https",
7551+
"node:inspector",
75517552
"node:module",
75527553
"node:net",
75537554
"node:os",

tests/integration/node_unit_tests.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ util::unit_test_factory!(
7474
fetch_test,
7575
http_test,
7676
http2_test,
77+
inspector_test,
7778
_randomBytes_test = internal / _randomBytes_test,
7879
_randomFill_test = internal / _randomFill_test,
7980
_randomInt_test = internal / _randomInt_test,

tests/unit_node/inspector_test.ts

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
// Copyright 2018-2024 the Deno authors. All rights reserved. MIT license.
2+
import inspector from "node:inspector";
3+
import { assertEquals } from "@std/assert/equals";
4+
5+
Deno.test("[node/inspector] - importing inspector works", () => {
6+
assertEquals(typeof inspector.open, "function");
7+
});

tools/core_import_map.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,7 @@
7878
"node:http": "../ext/node/polyfills/http.ts",
7979
"node:http2": "../ext/node/polyfills/http2.ts",
8080
"node:https": "../ext/node/polyfills/https.ts",
81+
"node:inspector": "../ext/node/polyfills/inspector.ts",
8182
"ext:deno_node/inspector.ts": "../ext/node/polyfills/inspector.ts",
8283
"ext:deno_node/internal_binding/_libuv_winerror.ts": "../ext/node/polyfills/internal_binding/_libuv_winerror.ts",
8384
"ext:deno_node/internal_binding/_listen.ts": "../ext/node/polyfills/internal_binding/_listen.ts",

0 commit comments

Comments
 (0)