test: check request without subdomain

Author: davidramiro

internal/api/api.go

@@ -52,10 +52,6 @@ func (u *UpdateApi) HandleUpdateRequest(c echo.Context) error {
 
 	subdomains := strings.Split(request.Subdomains, ",")
 
-	if subdomains == nil {
-		subdomains = []string{""}
-	}
-
 	for i := range subdomains {
 		logger.Debug().Msgf("handling request %d of %d", i+1, len(subdomains))
 
@@ -82,9 +78,8 @@ func (u *UpdateApi) HandleUpdateRequest(c echo.Context) error {
 	logger.Info().Int("updates", len(subdomains)).Msg("successfully created")
 
 	return c.String(http.StatusOK,
-		fmt.Sprintf("created %d entries for subdomains %s on %s: %s",
+		fmt.Sprintf("created %d entries on %s: %s",
 			len(subdomains),
-			request.Subdomains,
 			request.Domain,
 			request.IP),
 	)

internal/api/api_test.go

@@ -141,7 +141,33 @@ func TestUpdateEndpointSuccessSingleSubdomain(t *testing.T) {
 
 	if assert.NoError(t, updateApi.HandleUpdateRequest(c)) {
 		assert.Equal(t, http.StatusOK, rec.Code)
-		assert.Equal(t, "created 1 entries for subdomains bar on foo.com: 10.0.0.1", rec.Body.String())
+		assert.Equal(t, "created 1 entries on foo.com: 10.0.0.1", rec.Body.String())
+	}
+}
+
+func TestUpdateEndpointSuccessNoSubdomain(t *testing.T) {
+	e := echo.New()
+
+	q := make(url.Values)
+	q.Set("domain", "foo.com")
+	q.Set("ip", "10.0.0.1")
+	q.Set("registrar", "cloudflare")
+
+	req := httptest.NewRequest(http.MethodGet, fmt.Sprintf("/?%s", q.Encode()), nil)
+	rec := httptest.NewRecorder()
+	c := e.NewContext(req, rec)
+
+	cs := mockservices.NewMockDnsUpdateService(t)
+	cs.On("UpdateRecord", mock.Anything).Return(nil).Once()
+
+	sf := mockfactory.NewMockServiceFactory(t)
+	sf.On("Find", services.Registrar("cloudflare")).Return(cs, nil).Once()
+
+	updateApi = NewUpdateApi(sf)
+
+	if assert.NoError(t, updateApi.HandleUpdateRequest(c)) {
+		assert.Equal(t, http.StatusOK, rec.Code)
+		assert.Equal(t, "created 1 entries on foo.com: 10.0.0.1", rec.Body.String())
 	}
 }
 
@@ -168,7 +194,7 @@ func TestUpdateEndpointSuccessThreeSubdomains(t *testing.T) {
 
 	if assert.NoError(t, updateApi.HandleUpdateRequest(c)) {
 		assert.Equal(t, http.StatusOK, rec.Code)
-		assert.Equal(t, "created 3 entries for subdomains foo,bar,baz on foo.com: 10.0.0.1", rec.Body.String())
+		assert.Equal(t, "created 3 entries on foo.com: 10.0.0.1", rec.Body.String())
 	}
 }