Skip to content

Commit d4218be

Browse files
Fix: mutate text node #1485
1 parent d6e22c0 commit d4218be

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

packages/child/index.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import {
3131
capitalizeFirstLetter,
3232
getElementName,
3333
isDef,
34+
isElement,
3435
isolateUserCode,
3536
once,
3637
round,
@@ -979,7 +980,7 @@ This version of <i>iframe-resizer</> can auto detect the most suitable ${type} c
979980
}
980981

981982
function attachObservers() {
982-
const nodeList = getAllElements(document)()
983+
const nodeList = getAllElements(document.documentElement)()
983984

984985
log('Attaching Observers')
985986
createMutationObserver(mutationObserved)
@@ -1039,7 +1040,11 @@ This version of <i>iframe-resizer</> can auto detect the most suitable ${type} c
10391040
dimension.boundingClientRect(),
10401041
]
10411042

1042-
const getAllElements = (element) => () => {
1043+
const getAllElements = (node) => () => {
1044+
log('node:', node)
1045+
log('node type:', node?.nodeType)
1046+
if (!isElement(node)) return [node]
1047+
10431048
const selector = [
10441049
'* ',
10451050
'not(head)',
@@ -1063,7 +1068,7 @@ This version of <i>iframe-resizer</> can auto detect the most suitable ${type} c
10631068
if (hasIgnored)
10641069
selector.push(`not([${IGNORE_ATTR}])`, `not([${IGNORE_ATTR}] *)`)
10651070

1066-
return [element, ...element.querySelectorAll(selector.join(':'))]
1071+
return [node, ...node.querySelectorAll(selector.join(':'))]
10671072
}
10681073

10691074
function getOffsetSize(getDimension) {

packages/common/utils.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
export const isElement = (node) => node.nodeType === Node.ELEMENT_NODE
2+
13
export const isNumber = (value) => !Number.isNaN(value)
24

35
export const isolateUserCode = (func, ...val) =>

0 commit comments

Comments
 (0)