Document that in a nokeep-going build, PackageErrorMessageFunction throws NoSuchPackageException.

janakdr · copybara-github · commit c443e4a057ae · 2021-11-11T07:08:36.000-08:00
PiperOrigin-RevId: 409138713
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PackageErrorMessageFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/PackageErrorMessageFunction.java
@@ -32,6 +32,8 @@ public SkyValue compute(SkyKey skyKey, Environment env) throws InterruptedExcept
       pkgValue =
           (PackageValue) env.getValueOrThrow(PackageValue.key(pkgId), NoSuchPackageException.class);
     } catch (NoSuchPackageException e) {
+      // Note that in a no-keep-going build, this returned value is ignored by Skyframe, and the
+      // NoSuchPackageException will be propagated up to the caller of PackageErrorMessageFunction.
       return PackageErrorMessageValue.ofNoSuchPackageException(e.getMessage());
     }
     if (pkgValue == null) {

Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,8 @@ public SkyValue compute(SkyKey skyKey, Environment env) throws InterruptedExcept`
`32`	`32`	`pkgValue =`
`33`	`33`	`(PackageValue) env.getValueOrThrow(PackageValue.key(pkgId), NoSuchPackageException.class);`
`34`	`34`	`} catch (NoSuchPackageException e) {`
	`35`	`+ // Note that in a no-keep-going build, this returned value is ignored by Skyframe, and the`
	`36`	`+ // NoSuchPackageException will be propagated up to the caller of PackageErrorMessageFunction.`
`35`	`37`	`return PackageErrorMessageValue.ofNoSuchPackageException(e.getMessage());`
`36`	`38`	`}`
`37`	`39`	`if (pkgValue == null) {`