Skip to content

degrees <-> radians conversion clean-up #19077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TurboGit merged 62 commits into from
Jul 21, 2025
Merged

degrees <-> radians conversion clean-up #19077

TurboGit merged 62 commits into from
Jul 21, 2025

Conversation

@kofa73
Copy link
Contributor

@kofa73 kofa73 commented Jul 13, 2025

Standardising degrees <-> radians conversions, as requested:
#19026 (comment)

kofa73
kofa73 commented Jul 13, 2025
View reviewed changes
@kofa73 kofa73 changed the title Draft: degrees <-> radians conversion clean-up degrees <-> radians conversion clean-up Jul 13, 2025
@kofa73 kofa73 marked this pull request as ready for review July 13, 2025 12:48
@TurboGit TurboGit added this to the 5.4 milestone Jul 13, 2025
@TurboGit TurboGit added the scope: codebase making darktable source code easier to manage label Jul 13, 2025
@jenshannoschwalm
Copy link
Collaborator

jenshannoschwalm commented Jul 14, 2025

Very nice cleanup 👍

@da-phil
Copy link
Contributor

da-phil commented Jul 14, 2025

Indeed, very nice refactoring, thanks for that 👍

TurboGit
TurboGit requested changes Jul 17, 2025
View reviewed changes
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor some less minor. TIA.

kofa73 added 21 commits July 19, 2025 09:16
@kofa73
Added degrees <-> radians conversion functions to common/math.h
cfe80b5
@kofa73
Updated conversions in dtgtk/paint.c
194463e
@kofa73
Updated conversions in chart/deltaE.c
2c787df
@kofa73
Updated conversions in common/gpx.c
51e2227
@kofa73
Replaced pi with M_PI_F in chart/thinplate.c
e9a7f30
@kofa73
Replaced conversions in develop/masks/ellipse.c
8f5ffa2
@kofa73
Replaced conversions in develop/masks/gradient.c
e97940a
@kofa73
Added conversion factors to common/math.h
dbd138c
@kofa73
Minor conversion changes in iop/sigmoid.c
6aa83d1
@kofa73
Minor conversion change in develop/lightroom.c
7287a6d
@kofa73
Minor conversion change in iop/primaries.c
b030592
@kofa73
Minor conversion change in iop/overlay.c
14ac1c6
@kofa73
Conversion and related changes in iop/graduatednd.c
6c3894c
@kofa73
Restored '3.145 / 180' conversions in paint.c, looks intentional.
2e7e68d
@kofa73
Updated conversions on iop/ashift.c
30c7a9e
@kofa73
Updated conversions on gui/guides.c
0c593fa
@kofa73
Updated conversions on iop/ashift_lsd.c
898646a
@kofa73
Updated conversions on iop/blurs.c
7d1e976
@kofa73
Updated conversions in gui/gtk.c
e75d743
@kofa73
Made new constant + functions static in common/math.h
0f99fa0
@kofa73
Restoring imports in gui/gtk.c (OSX build fails)
ada8495
kofa73 added 26 commits July 19, 2025 14:39
@kofa73
Const cleanup in src/common/math.h
b0aa201
@kofa73
Const cleanup in src/develop/lightroom.c
61c2720
@kofa73
Const cleanup in src/develop/masks/ellipse.c
45062ae
@kofa73
Const cleanup in src/develop/masks/gradient.c
b18d8af
@kofa73
Const cleanup in src/develop/masks/masks.c,src/develop/masks.h
b205066
@kofa73
Const cleanup in src/dtgtk/paint.c
589a8e2
@kofa73
Const cleanup in src/gui/gtk.c+h
f41af46
@kofa73
Const cleanup in src/gui/guides.c+h
cd109d9
@kofa73
Const cleanup in src/iop/ashift.c
d158929
@kofa73
Const cleanup in src/iop/ashift_lsd.c
22788db
@kofa73
Const cleanup in src/iop/blurs.c
ec85e49
@kofa73
Const cleanup in src/iop/channelmixerrgb.c
43cfdd3
@kofa73
Const cleanup in src/iop/clipping.c
b8eae81
@kofa73
Const cleanup in src/iop/colorbalancergb.c
230a73b
@kofa73
Const cleanup in src/iop/colorequal.c
8371bae
@kofa73
Const cleanup in src/iop/filmicrgb.c
3dba9d6
@kofa73
Const cleanup in src/iop/graduatednd.c
9ea60a1
@kofa73
Const cleanup in src/iop/liquify.c
a3a025e
@kofa73
Const cleanup in src/iop/overlay.c
74b273a
@kofa73
Const cleanup in src/iop/primaries.c
fb4732e
@kofa73
Const cleanup in src/iop/rotatepixels.c
38bf82a
@kofa73
Const cleanup in src/iop/sigmoid.c
2f25b90
@kofa73
Const cleanup in src/iop/toneequal.c
c2239f7
@kofa73
Const cleanup in src/iop/watermark.c
88be97d
@kofa73
Const cleanup in src/libs/histogram.c
9e18df9
@kofa73
Const cleanup in src/libs/histogram.c
cea5215
@kofa73 kofa73 mentioned this pull request Jul 20, 2025
Merged
TurboGit
TurboGit approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this nice cleanup!

@TurboGit TurboGit merged commit 8203ab0 into darktable-org:master Jul 21, 2025
6 checks passed
@kofa73 kofa73 deleted the deg2rad branch July 21, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TurboGit TurboGit TurboGit approved these changes

Assignees

No one assigned

Labels

scope: codebase making darktable source code easier to manage

Projects

None yet

Milestone

5.4

Development

Successfully merging this pull request may close these issues.

4 participants

@kofa73 @jenshannoschwalm @da-phil @TurboGit