Fix build with clang-21 #19038
Merged
Fix build with clang-21 #19038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error Message:
darktable-5.2.0/data/kernels/soften.cl:33:18: error: use of undeclared identifier 'read_imagef'
33 | float4 pixel = read_imagef(in, sampleri, (int2)(x, y));
| ^~~~~~~~~~~
llvm/llvm-project@c1aebd4
wrapped all the image function declarations in the __IMAGE_SUPPORT__
macro, so darktable needs to define this macro in order to use these
functions.
TurboGit
added
bugfix
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error Message:
darktable-5.2.0/data/kernels/soften.cl:33:18: error: use of undeclared identifier 'read_imagef'
33 | float4 pixel = read_imagef(in, sampleri, (int2)(x, y));
| ^~~~~~~~~~~
llvm/llvm-project@c1aebd4 wrapped all the image function declarations in the IMAGE_SUPPORT macro, so darktable needs to define this macro in order to use these functions.