A port of Blender's AgX to darktable#19026

Merged

TurboGit merged 40 commits intodarktable-org:masterfrom

Sep 11, 2025

Commits on Sep 8, 2025

A port of Blender's AgX to darktable
kofa73
committed
Fix side effect of transition point limits
kofa73
committed
Added inline, conts, formatted according to PR comments
kofa73
committed
More formatting + inline
kofa73
committed
A tiny tweak to the outgoing params, bringing the largest matrix coefficient error below 1%
kofa73
committed
Moved the 'primaries from preset' combo + apply button above 'base primaries', as the loaded values apply to the base, as well
kofa73
committed
Removed tiling_callback (not needed for a simple pixel-wise module)
kofa73
committed
Converted some parameters to percentages
kofa73
committed
Extracted duplicated code to find the colourout module into _dt_ioppr_find_colorout_module
kofa73
committed
Extracted deg2rad to common/math.h, updated conversions
kofa73
committed
Removed unnecessary modifications from iop_profile.c
kofa73
committed
Added degrees/radians conversions to math.h (same as what we'll have on master later). agx (v4) now uses fractional numbers internally, only the UI has percentages. Reformatted with 'if()', 'for()'…
kofa73
committed
agx: float literals, const
kofa73
committed
revert unnecessary change in iop_profile.h
kofa73
committed
agx: removed tiling; added aliases; removed custom hash function; initialised split slider declaration to null.
kofa73
committed
agx: formatting, alignment
kofa73
committed
agx: moved default_colorspace; multiline assignment = at end of line; missed initialisations; renaming; no parameter reassignment; static function name starts with _; restored custom hash to fix co…
kofa73
committed
agx: properly applied hash function suggestion
kofa73
committed
agx: minor comment updates; swapped offset and scale (in the look section) on the UI. Display curve y labels as %. Draw toe/shoulder start points.
kofa73
committed
agx: Renamed dt_iop_agx_user_params_t to dt_iop_agx_params_t, its pointers to p, gui_data pointers go g
kofa73
committed
agx: Replace duplicate curve control sliders + synch with reparenting on tab switch
kofa73
committed
agx: Added DT_IOP_SECTION_FOR_PARAMS
kofa73
committed
agx: Scale contrast according to gamma to maintain midtone contrast around the pivot. Fixed security_factor scaling bug introduced during percentage -> fractional conversion.
kofa73
committed
agx: Use N_ with DT_IOP_SECTION_FOR_PARAMS
kofa73
committed
agx: minor variable name clean-up
kofa73
committed
agx: _lerp_hue is now branch-free, including sanitisation of result; input is no longer sanitised, because _dt_RGB_2_Hue now garantees 0 <= hue < 1.
kofa73
committed
agx: Further optimisation of _lerp_hue
kofa73
committed
agx: calculate matrices only in process(), not in commit_params()
kofa73
committed
agx: one param per line for _agx_tone_mapping()
kofa73
committed
Revert "agx: calculate matrices only in process(), not in commit_params()"
kofa73
committed
agx: In commit_params(), copy the parameters that are required to calculate the matrices later, instead of computing them. This is done in process(), where we have access to the actual processing p…
kofa73
committed
send look box to the bottom

blitzgneisserin
authored and
kofa73
committed
basic curve parameters on both tabs

blitzgneisserin
authored and
kofa73
committed
Minor indentation and packing fixes
kofa73
committed
agx: marked some functions as 'inline'; replaced famf with the safe macro DT_FMA
kofa73
committed
agx: Optimisations for common scenarios: base profile = working profile; look neutral; restore hue = 0
kofa73
committed
agx: Make sure exposure pickers deliver values within the sliders' hard bounds
kofa73
committed
agx: Use global max3f, min3f
kofa73
committed
agx: Fixed gamma contrast compensation
kofa73
committed
agx: Added plugins/darkroom/agx/look_always_visible to keep 'look' controls always visible
kofa73
committed