Extracted deg2rad to common/math.h, updated conversions

Author: kofa73

src/common/math.h

@@ -749,6 +749,11 @@ static inline void dt_vector_sin(const dt_aligned_pixel_t arg,
     sine[c] = scaled[c] * (p[c] * (abs_scaled[c] - one[c]) + one[c]);
 }
 
+inline float deg2rad(const float degrees)
+{
+  return degrees * M_PI_F / 180.f;
+}
+
 // clang-format off
 // modelines: These editor modelines have been set for all relevant files by tools/update_modelines.py
 // vim: shiftwidth=2 expandtab tabstop=2 cindent

src/iop/agx.c

@@ -2163,11 +2163,6 @@ void gui_init(dt_iop_module_t *self)
   gui_update(self);
 }
 
-static float _degrees_to_radians(const float degrees)
-{
-  return degrees * M_PI_F / 180.f;
-}
-
 static void _set_neutral_params(dt_iop_agx_user_params_t *user_params)
 {
   user_params->look_slope = 1.0f;
@@ -2277,15 +2272,15 @@ void init_presets(dt_iop_module_so_t *self)
   user_params.red_inset = 0.1f;
   user_params.green_inset = 0.1f;
   user_params.blue_inset = 0.15f;
-  user_params.red_rotation = _degrees_to_radians(2.f);
-  user_params.green_rotation = _degrees_to_radians(-1.f);
-  user_params.blue_rotation = _degrees_to_radians(-3.f);
+  user_params.red_rotation = deg2rad(2.f);
+  user_params.green_rotation = deg2rad(-1.f);
+  user_params.blue_rotation = deg2rad(-3.f);
   user_params.red_outset = 0.1f;
   user_params.green_outset = 0.1f;
   user_params.blue_outset = 0.15f;
-  user_params.red_unrotation = _degrees_to_radians(2.f);
-  user_params.green_unrotation = _degrees_to_radians(-1.f);
-  user_params.blue_unrotation = _degrees_to_radians(-3.f);
+  user_params.red_unrotation = deg2rad(2.f);
+  user_params.green_unrotation = deg2rad(-1.f);
+  user_params.blue_unrotation = deg2rad(-3.f);
   // Don't restore purity - try to avoid posterization.
   user_params.master_outset_ratio = 0.0f;
   user_params.master_unrotation_ratio = 1.0f;

src/iop/colorequal.c

@@ -454,7 +454,7 @@ void _mean_gaussian(float *const buf,
 #define ANGLE_SHIFT +20.f
 static inline float _deg_to_rad(const float angle)
 {
-  return (angle + ANGLE_SHIFT) * M_PI_F / 180.f;
+  return deg2rad(angle + ANGLE_SHIFT);
 }
 
 /* We use precalculated data for the logistic weighting function for performance and stability
@@ -1723,7 +1723,7 @@ static inline void _periodic_RBF_interpolate(float nodes[NODES],
     // every degree.  We use un-offset angles here, since thue hue
     // offset is merely a GUI thing, only relevant for user-defined
     // nodes.
-    const float hue = (float)i * 360.0f / (float)LUT_ELEM * M_PI_F / 180.f - M_PI_F;
+    const float hue = deg2rad((float)i * 360.0f / (float)LUT_ELEM) - M_PI_F;
     LUT[i] = 0.f;
 
     for(int k = 0; k < NODES; k++)

src/iop/sigmoid.c

@@ -272,8 +272,6 @@ void init_presets(dt_iop_module_so_t *self)
                              self->version(), &p, sizeof(p), 1,
                              DEVELOP_BLEND_CS_RGB_SCENE);
 
-  const float DEG_TO_RAD = M_PI_F / 180.f;
-
   // smooth - a preset that utilizes the primaries feature
   p.middle_grey_contrast = 1.5f;
   // Allow a little bit more room for the highlights
@@ -284,9 +282,9 @@ void init_presets(dt_iop_module_so_t *self)
   p.red_inset = 0.1f;
   p.green_inset = 0.1f;
   p.blue_inset = 0.15f;
-  p.red_rotation = 2.f * DEG_TO_RAD;
-  p.green_rotation = -1.f * DEG_TO_RAD;
-  p.blue_rotation = -3.f * DEG_TO_RAD;
+  p.red_rotation = deg2rad(2.f);
+  p.green_rotation = deg2rad(-1.f);
+  p.blue_rotation = deg2rad(-3.f);
   // Don't restore purity - try to avoid posterization.
   p.purity = 0.f;
   // Constant base primaries (not dependent on work profile) to