Skip to content

Commit b77de69

Browse files
committed
Re-enable ARM builds
1 parent dfa3b43 commit b77de69

File tree

4 files changed

+15
-9
lines changed

4 files changed

+15
-9
lines changed

.github/workflows/docker.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,9 @@ jobs:
6060
runs-on: ${{ github.repository == 'sigp/lighthouse' && fromJson('["self-hosted", "linux", "release"]') || 'ubuntu-22.04' }}
6161
strategy:
6262
matrix:
63-
# FIXME(sproul) re-enable ARM builds
64-
binary: [x86_64,
63+
binary: [aarch64,
64+
aarch64-portable,
65+
x86_64,
6566
x86_64-portable]
6667
features: [
6768
{version_suffix: "", env: "gnosis,slasher-lmdb,slasher-mdbx,jemalloc"},
@@ -141,10 +142,9 @@ jobs:
141142
echo "${DOCKER_PASSWORD}" | docker login --username ${DOCKER_USERNAME} --password-stdin
142143
143144
- name: Create and push multiarch manifest
144-
# FIXME(sproul): Fix ARM builds and put this back
145-
# ${IMAGE_NAME}:${VERSION}-arm64${VERSION_SUFFIX}${{ matrix.modernity }} \
146145
run: |
147146
docker buildx imagetools create -t ${IMAGE_NAME}:${VERSION}${VERSION_SUFFIX}${{ matrix.modernity }} \
147+
${IMAGE_NAME}:${VERSION}-arm64${VERSION_SUFFIX}${{ matrix.modernity }} \
148148
${IMAGE_NAME}:${VERSION}-amd64${VERSION_SUFFIX}${{ matrix.modernity }};
149149
150150
build-docker-lcli:

.github/workflows/release.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,15 +29,22 @@ jobs:
2929
build:
3030
name: Build Release
3131
strategy:
32-
# FIXME(sproul): fix xdelta build for ARM
3332
matrix:
34-
arch: [x86_64-unknown-linux-gnu,
33+
arch: [aarch64-unknown-linux-gnu,
34+
aarch64-unknown-linux-gnu-portable,
35+
x86_64-unknown-linux-gnu,
3536
x86_64-unknown-linux-gnu-portable,
3637
x86_64-apple-darwin,
3738
x86_64-apple-darwin-portable,
3839
x86_64-windows,
3940
x86_64-windows-portable]
4041
include:
42+
- arch: aarch64-unknown-linux-gnu
43+
runner: ${{ github.repository == 'sigp/lighthouse' && fromJson('["self-hosted", "linux", "release", "large"]') || 'ubuntu-latest' }}
44+
profile: maxperf
45+
- arch: aarch64-unknown-linux-gnu-portable
46+
runner: ${{ github.repository == 'sigp/lighthouse' && fromJson('["self-hosted", "linux", "release", "large"]') || 'ubuntu-latest' }}
47+
profile: maxperf
4148
- arch: x86_64-unknown-linux-gnu
4249
runner: ${{ github.repository == 'sigp/lighthouse' && fromJson('["self-hosted", "linux", "release", "large"]') || 'ubuntu-latest' }}
4350
profile: maxperf

Cargo.lock

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,7 @@ url = "2"
168168
uuid = { version = "0.8", features = ["serde", "v4"] }
169169
# TODO update to warp 0.3.6 after released.
170170
warp = { git = "https://github.com/seanmonstar/warp.git", default-features = false, features = ["tls"] }
171-
# FIXME(sproul): restore upstream
172-
xdelta3 = { git = "http://github.com/michaelsproul/xdelta3-rs", rev="cb3be8d445c0ed2adf815c62b14c197ca19bd94a" }
171+
xdelta3 = { git = "http://github.com/michaelsproul/xdelta3-rs", rev="d12f71b36a55b5ca0247a38151fb7c2be5c0e742" }
173172
zeroize = { version = "1", features = ["zeroize_derive"] }
174173
zip = "0.6"
175174
zstd = "0.11.2"

0 commit comments

Comments
 (0)