Skip to content

Commit 3759825

Browse files
authored
Upgrade colmap to 3.13.0 and update hloc tag. (#147)
* upgrade colmap to 3.13.0 and update hloc tag. * update hloc tag.
1 parent be5c3e1 commit 3759825

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

requirements.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ yacs
2222
pytest
2323
numpy<=1.26.4 # Tag numpy 1.26.4 for Open3D issue (https://github.com/numpy/numpy/issues/26853)
2424
open3d==0.18.0
25-
pycolmap>=3.12.6
25+
pycolmap==3.13.0
2626
ruff==0.6.7
2727
clang-format==19.1.0
2828

2929
pytlsd@git+https://github.com/iago-suarez/pytlsd.git@4180ab8
3030
deeplsd@git+https://github.com/cvg/DeepLSD.git@88c589d
3131
gluestick@git+https://github.com/cvg/GlueStick.git@7d81673
32-
-e git+https://github.com/cvg/Hierarchical-Localization.git@1252817#egg=hloc
32+
-e git+https://github.com/cvg/Hierarchical-Localization.git@a3e5731#egg=hloc

src/limap/pointsfm/colmap_sfm.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
pairs_from_exhaustive,
1515
triangulation,
1616
)
17-
from hloc.utils.io import open_colmap_database
1817
from limap.pointsfm.model_converter import convert_imagecols_to_colmap
1918

2019

@@ -24,7 +23,7 @@ def import_images_with_known_cameras(image_dir, database_path, imagecols):
2423
assert len(image_name_list) == len(image_ids)
2524

2625
# connect to the database
27-
with open_colmap_database(database_path) as db:
26+
with pycolmap.Database.open(database_path) as db:
2827
# add camera
2928
for cam_id in imagecols.get_cam_ids():
3029
cam = imagecols.cam(cam_id)
@@ -139,7 +138,7 @@ def run_hloc_matches(
139138
image_path, db_path, imagecols
140139
) # use cameras and id mapping
141140
image_ids = reconstruction.get_image_ids(db_path)
142-
with open_colmap_database(db_path) as db:
141+
with pycolmap.Database.open(db_path) as db:
143142
reconstruction.import_features(image_ids, db, feature_path)
144143
reconstruction.import_matches(
145144
image_ids, db, sfm_pairs, match_path, None, None

0 commit comments

Comments
 (0)