internal/core/adt: simplify code

We know that group should always be set after
a call to getKeyedCC, so simplify the code.

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: I12de7c5c3434474a4ce4c4bad83bc453e95f6a57
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1202776
Reviewed-by: Matthew Sackman <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>

Author: mpvl

internal/core/adt/fields.go

@@ -457,26 +457,18 @@ func (cc *closeContext) assignConjunct(ctx *OpContext, root *closeContext, c Con
 
 	c.CloseInfo.cc = nil
 
-	var group ConjunctGroup
-	if arc.group != nil {
-		group = *arc.group
-	}
-	pos = len(group)
+	group := arc.group
+	pos = len(*group)
 
-	added = !check || !hasConjunct(group, c)
+	added = !check || !hasConjunct(*group, c)
 	if added {
 		c.CloseInfo.cc = arc
 
 		if c.CloseInfo.cc.src != arc.src {
 			panic("Inconsistent src")
 		}
 
-		group = append(group, c)
-		if arc.group == nil {
-			arc.group = &group
-		} else {
-			*arc.group = group
-		}
+		*group = append(*group, c)
 	}
 
 	return arc, pos, added