internal/core/adt: remove unused test code

The TODO about externalDeps has been out of date since new closedness
was done in https://cuelang.org/cl/1210790, which removed the field.

skipFiles hasn't done anything for evalv3 for months now, as it has
been feature complete for a while. Keeping the code around isn't
harmful per se, but walking all syntax trees isn't free either.
Removing the step cuts `go test` by about 100ms, given that we don't
run any test or subtest in parallel at the moment.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: Ic16ed5fefe5a30fee389569490f827fdbef54502
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1218032
Reviewed-by: Marcel van Lohuizen <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>

Author: mvdan

internal/core/adt/eval_test.go

@@ -24,11 +24,9 @@ import (
 	"golang.org/x/tools/txtar"
 
 	"cuelang.org/go/cue"
-	"cuelang.org/go/cue/ast"
 	"cuelang.org/go/cue/cuecontext"
 	"cuelang.org/go/cue/errors"
 	"cuelang.org/go/cue/stats"
-	"cuelang.org/go/cue/token"
 	"cuelang.org/go/internal"
 	"cuelang.org/go/internal/core/adt"
 	"cuelang.org/go/internal/core/debug"
@@ -64,12 +62,6 @@ func TestEvalV2(t *testing.T) {
 }
 
 func TestEvalV3(t *testing.T) {
-	// TODO: remove use of externalDeps for processing. Currently, enabling
-	// this would fix some issues, but also introduce some closedness bugs.
-	// As a first step, we should ensure that the temporary hack of using
-	// externalDeps to agitate pending dependencies is replaced with a
-	// dedicated mechanism.
-	//
 	adt.DebugDeps = true // check unmatched dependencies.
 
 	cuedebug.Init()
@@ -85,42 +77,11 @@ func TestEvalV3(t *testing.T) {
 		test.ToDo = nil
 	}
 
-	var ran, skipped, errorCount int
-
+	var errorCount int
 	test.Run(t, func(t *cuetxtar.Test) {
-		if reason := skipFiles(t.Instance().Files...); reason != "" {
-			skipped++
-			t.Skip(reason)
-		}
-		ran++
-
 		errorCount += runEvalTest(t, internal.EvalV3, flags)
 	})
-
-	t.Logf("ran: %d, skipped: %d, nodeErrors: %d",
-		ran, skipped, errorCount)
-}
-
-// skipFiles returns true if the given files contain CUE that is not yet handled
-// by the development version of the evaluator.
-func skipFiles(a ...*ast.File) (reason string) {
-	// Skip disjunctions.
-	fn := func(n ast.Node) bool {
-		switch x := n.(type) {
-		case *ast.BinaryExpr:
-			if x.Op == token.OR {
-				// Uncomment to disable disjunction testing.
-				// NOTE: keep around until implementation of disjunctions
-				// is complete.
-				// reason = "disjunctions"
-			}
-		}
-		return true
-	}
-	for _, f := range a {
-		ast.Walk(f, fn, nil)
-	}
-	return reason
+	t.Logf("nodeErrors: %d", errorCount)
 }
 
 func runEvalTest(t *cuetxtar.Test, version internal.EvaluatorVersion, flags cuedebug.Config) (errorCount int) {