internal/core/dep: fix handling sharing in non-rooted nodes

If a non-rooted/anonymous node uses structure sharing,
we need to treat the references within the
structure-shared node as non-rooted as well.
The reasons for this is that otherwise this reference does
not have an addressable location.

It is hard to detect this from the context of a structure-
shared node. In CL https://cuelang.org/cl/1202268, this
was done by investigating the context. For this we
need to be slightly more aggressive picking the
current reference.

Test changes:
- issue2247: reverted to the state before cl/1202268.
             Not great, but not wrong.
- selfref:   one good improvement, one regression.
- import:    reverts to V2, but not a huge deal
- let2:      now refers to references in let, instead
             of original. This is not wrong per se,
             and maybe even desirable.

Fixes #3646

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: I88f89720be95547bb8f897c34f041af6fb8d65eb
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1207402
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>
Reviewed-by: Matthew Sackman <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>

Author: mpvl

cmd/cue/cmd/testdata/script/cmd_depissue.txtar

@@ -0,0 +1,30 @@
+# Issue #3646
+
+env CUE_EXPERIMENT=evalv3=0
+exec cue cmd two
+stdout 'msg.*hello'
+
+env CUE_EXPERIMENT=evalv3=1
+exec cue cmd two
+stdout 'msg.*hello'
+
+-- input_tool.cue --
+package p
+
+import (
+    "tool/exec"
+    "encoding/json"
+)
+
+command: {
+    one: exec.Run & {
+        stdin: "{\"msg\": \"hello\"}"
+        cmd: ["cat"]
+        stdout: string
+    }
+    two: exec.Run & {
+        let data = json.Unmarshal(one.stdout)
+        cmd: ["cat"] // "true" is printed for each json value read
+        stdin: json.Marshal(data) + "\n"
+    }
+}

cmd/cue/cmd/testdata/script/cmd_print.txtar

@@ -1,3 +1,8 @@
+env CUE_EXPERIMENT=evalv3=0
+exec cue cmd print
+cmp stdout expect-stdout
+
+env CUE_EXPERIMENT=evalv3=1
 exec cue cmd print
 cmp stdout expect-stdout
 

cmd/cue/cmd/testdata/script/def_issue3646.txtar

@@ -1,8 +1,13 @@
+env CUE_EXPERIMENT=evalv3=0
 exec cue def --inline-imports ./p1
 stdin stdout
+exec cue eval --out=json -
+cmp stdout stdout.golden
 
-# TODO Fix this test
-! exec cue eval --out=json -
+env CUE_EXPERIMENT=evalv3=1
+exec cue def --inline-imports ./p1
+stdin stdout
+exec cue eval --out=json -
 cmp stdout stdout.golden
 
 -- go.mod --
@@ -38,3 +43,7 @@ package p2
 
 regionMap: #RegionMap
 -- stdout.golden --
+{
+    "r": "us-east-1",
+    "shortRegionName": "ue1"
+}

internal/core/dep/dep.go

@@ -476,7 +476,7 @@ func (c *visitor) reportDependency(env *adt.Environment, ref adt.Resolver, v *ad
 		}
 		v = w
 	}
-	if len(c.pathStack) == 0 && c.topRef != nil {
+	if inspect && len(c.pathStack) == 0 && c.topRef != nil {
 		altRef = c.topRef
 	}
 

internal/core/dep/testdata/let2.txtar

@@ -1,3 +1,6 @@
+# TODO:
+# out/dependencies/all: origin should ideally be Let reference not v
+
 -- in.cue --
 v: w: u: d: 0
 
@@ -24,24 +27,29 @@ a: b: {
 -- out/dependencies/field --
 line  reference    path of resulting vertex
 -- out/dependencies-v3/all --
-line  reference    path of resulting vertex
-12:   X1        => v.w
-13:   X2        => v.w
-14:   X3.w      => v.w
-20:   Y1        => v
-21:   Y2        => v
+line  reference                path of resulting vertex
+3:    {c: v}.c.w            => v.w
+4:    {c: {out: v}.out}.c.w => v.w
+14:   X3.w                  => v.w
+7:    v                     => v
+8:    v                     => v
 -- diff/-out/dependencies-v3/all<==>+out/dependencies/all --
 diff old new
 --- old
 +++ new
-@@ -2,5 +2,5 @@
- 12:   X1        => v.w
- 13:   X2        => v.w
- 14:   X3.w      => v.w
+@@ -1,6 +1,6 @@
+-line  reference    path of resulting vertex
+-12:   X1        => v.w
+-13:   X2        => v.w
+-14:   X3.w      => v.w
 -7:    v         => v
 -8:    v         => v
-+20:   Y1        => v
-+21:   Y2        => v
++line  reference                path of resulting vertex
++3:    {c: v}.c.w            => v.w
++4:    {c: {out: v}.out}.c.w => v.w
++14:   X3.w                  => v.w
++7:    v                     => v
++8:    v                     => v
 -- out/dependencies/all --
 line  reference    path of resulting vertex
 12:   X1        => v.w

internal/core/dep/testdata/selfref.txtar

@@ -1,4 +1,8 @@
 #Issue: 1405
+
+# TODO:
+# One X.enabled should be a.#combined.enabled
+
 -- in.cue --
 a: {
 	command: alias: {

internal/core/export/testdata/selfcontained/import.txtar

@@ -1,5 +1,7 @@
 #inlineImports: true
 
+# TODO: slightly more correct is for _hidden_567475F3.a to be `b` and not resolve.
+
 -- cue.mod/module.cue --
 module: "mod.test/a"
 language: version: "v0.9.0"
@@ -120,7 +122,7 @@ let F = {
 let W = {
 	a: _hidden_567475F3
 	_hidden_567475F3: {
-		a: b
+		a: 1
 	}
 	b: 1
 	x: {

internal/core/export/testdata/selfcontained/issue2247.txtar

@@ -43,8 +43,12 @@ f: {
 	e: {
 		out: c
 	}.out
-	f: Q
-	g: Q
+	f: {
+		out: Q
+	}.out
+	g: {
+		out: Q
+	}.out
 	h: {
 		out: {
 			r: {
@@ -71,7 +75,7 @@ let K = {
 diff old new
 --- old
 +++ new
-@@ -25,7 +25,7 @@
+@@ -29,7 +29,7 @@
  	x: [...int]
  }
 
@@ -88,8 +92,12 @@ f: {
 	e: {
 		out: c
 	}.out
-	f: Q
-	g: Q
+	f: {
+		out: Q
+	}.out
+	g: {
+		out: Q
+	}.out
 	h: {
 		out: {
 			r: {