internal/core/adt: add test case for selection problem

We add two test cases for which the value of #Step
should be the same in either case. This is the case
for eval v2, but not eval v3.

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: Iee04f55e5745e12fb9b08d9d121c85bab14fa95b
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1202906
Reviewed-by: Daniel Martí <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>

Author: mpvl

cue/testdata/cycle/inline_non_recursive.txtar

@@ -79,15 +79,29 @@ issue3182: {
 		}.p.x.y
 	}
 }
+-- select.cue --
+// The value of #Step should be consistent between these test cases.
+select: direct: {
+	#Step: (#Job & {opt: _}).opt
+	#Job: matchN(1, [#NormalJob])
+}
+select: indirect: {
+	#Step: #Job.opt
+	#Job: matchN(1, [#NormalJob]) & {opt: _}
+}
+#NormalJob: {
+	req!: int
+	opt?: run?: string
+}
 -- out/evalalpha/stats --
-Leaks:  272
+Leaks:  302
 Freed:  0
 Reused: 0
-Allocs: 272
+Allocs: 302
 Retain: 0
 
-Unifications: 251
-Conjuncts:    1299
+Unifications: 280
+Conjuncts:    1396
 Disjuncts:    0
 -- out/evalalpha --
 Errors:
@@ -192,28 +206,57 @@ Result:
     }
     third: (int){ 1 }
   }
+  select: (struct){
+    direct: (struct){
+      #Step: (_|_){
+        // [incomplete] invalid value {opt:_} (does not satisfy matchN(1, [~(#NormalJob)])): 0 matched, expected 1:
+        //     ./select.cue:4:8
+        //     ./select.cue:3:10
+        //     ./select.cue:4:15
+      }
+      #Job: (_){ matchN(1, (#list){
+          0: (_|_){// &[〈3;#NormalJob〉]
+          }
+        }) }
+    }
+    indirect: (struct){
+      #Step: (_){ _ }
+      #Job: (_|_){
+        // [incomplete] select.indirect.#Job: invalid value {opt:_} (does not satisfy matchN(1, [~(#NormalJob)])): 0 matched, expected 1:
+        //     ./select.cue:8:8
+        //     ./select.cue:8:15
+        opt: (_){ _ }
+      }
+    }
+  }
+  #NormalJob: (#struct){
+    req!: (int){ int }
+    opt?: (#struct){
+      run?: (string){ string }
+    }
+  }
 }
 -- diff/-out/evalalpha/stats<==>+out/eval/stats --
 diff old new
 --- old
 +++ new
 @@ -1,9 +1,9 @@
--Leaks:  306
--Freed:  405
--Reused: 401
--Allocs: 310
--Retain: 1066
-+Leaks:  272
+-Leaks:  309
+-Freed:  437
+-Reused: 429
+-Allocs: 317
+-Retain: 1074
++Leaks:  302
 +Freed:  0
 +Reused: 0
-+Allocs: 272
++Allocs: 302
 +Retain: 0
 
--Unifications: 711
--Conjuncts:    2759
--Disjuncts:    1446
-+Unifications: 251
-+Conjuncts:    1299
+-Unifications: 746
+-Conjuncts:    2813
+-Disjuncts:    1485
++Unifications: 280
++Conjuncts:    1396
 +Disjuncts:    0
 -- diff/-out/evalalpha<==>+out/eval --
 diff old new
@@ -253,19 +296,47 @@ diff old new
            }
          }
        }
+@@ -102,9 +102,14 @@
+   }
+   select: (struct){
+     direct: (struct){
+-      #Step: (_){ _ }
++      #Step: (_|_){
++        // [incomplete] invalid value {opt:_} (does not satisfy matchN(1, [~(#NormalJob)])): 0 matched, expected 1:
++        //     ./select.cue:4:8
++        //     ./select.cue:3:10
++        //     ./select.cue:4:15
++      }
+       #Job: (_){ matchN(1, (#list){
+-          0: (_|_){// 〈3;#NormalJob〉
++          0: (_|_){// &[〈3;#NormalJob〉]
+           }
+         }) }
+     }
+@@ -111,7 +116,7 @@
+     indirect: (struct){
+       #Step: (_){ _ }
+       #Job: (_|_){
+-        // [incomplete] select.indirect.#Job: invalid value {opt:_} (does not satisfy matchN(1, [{req!:int,opt?:{run?:string}}])): 0 matched, expected 1:
++        // [incomplete] select.indirect.#Job: invalid value {opt:_} (does not satisfy matchN(1, [~(#NormalJob)])): 0 matched, expected 1:
+         //     ./select.cue:8:8
+         //     ./select.cue:8:15
+         opt: (_){ _ }
+-- diff/todo/p1 --
+select: values of #Step differ
 -- diff/todo/p3 --
 Error positions.
 Incorrect path due to structure sharing.
 -- out/eval/stats --
-Leaks:  306
-Freed:  405
-Reused: 401
-Allocs: 310
-Retain: 1066
+Leaks:  309
+Freed:  437
+Reused: 429
+Allocs: 317
+Retain: 1074
 
-Unifications: 711
-Conjuncts:    2759
-Disjuncts:    1446
+Unifications: 746
+Conjuncts:    2813
+Disjuncts:    1485
 -- out/eval --
 Errors:
 issue3182.first.t2.x.b: structural cycle
@@ -369,6 +440,30 @@ Result:
     }
     third: (int){ 1 }
   }
+  select: (struct){
+    direct: (struct){
+      #Step: (_){ _ }
+      #Job: (_){ matchN(1, (#list){
+          0: (_|_){// 〈3;#NormalJob〉
+          }
+        }) }
+    }
+    indirect: (struct){
+      #Step: (_){ _ }
+      #Job: (_|_){
+        // [incomplete] select.indirect.#Job: invalid value {opt:_} (does not satisfy matchN(1, [{req!:int,opt?:{run?:string}}])): 0 matched, expected 1:
+        //     ./select.cue:8:8
+        //     ./select.cue:8:15
+        opt: (_){ _ }
+      }
+    }
+  }
+  #NormalJob: (#struct){
+    req!: (int){ int }
+    opt?: (#struct){
+      run?: (string){ string }
+    }
+  }
 }
 -- out/compile --
 --- in.cue
@@ -525,3 +620,32 @@ Result:
     }
   }
 }
+--- select.cue
+{
+  select: {
+    direct: {
+      #Step: (〈0;#Job〉 & {
+        opt: _
+      }).opt
+      #Job: matchN(1, [
+        〈3;#NormalJob〉,
+      ])
+    }
+  }
+  select: {
+    indirect: {
+      #Step: 〈0;#Job〉.opt
+      #Job: (matchN(1, [
+        〈3;#NormalJob〉,
+      ]) & {
+        opt: _
+      })
+    }
+  }
+  #NormalJob: {
+    req!: int
+    opt?: {
+      run?: string
+    }
+  }
+}