cue/stats: remove unused CloseIDElems counter

The CloseIDElems counter was tracking the size
of ReqSet during closedness checks, upcoming
changes make this counter deprecated.
We remove it to minimize diff.

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: Ia93cd81406c4aed59215a032f84bdbf0a0f4e945
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1218833
Reviewed-by: Daniel Martí <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>

Author: mpvl

cmd/cue/cmd/testdata/script/stats.txtar

@@ -50,7 +50,6 @@ contents overwritten
         "Disjuncts": 2,
         "Notifications": 0,
         "Conjuncts": 8,
-        "CloseIDElems": 0,
         "NumCloseIDs": 2,
         "ConjunctInfos": 6,
         "MaxConjunctInfos": 2,
@@ -72,7 +71,6 @@ CUE: {
 	Disjuncts:        2
 	Notifications:    0
 	Conjuncts:        8
-	CloseIDElems:     0
 	NumCloseIDs:      2
 	ConjunctInfos:    6
 	MaxConjunctInfos: 2
@@ -93,7 +91,6 @@ CUE:
   Disjuncts: 2
   Notifications: 0
   Conjuncts: 8
-  CloseIDElems: 0
   NumCloseIDs: 2
   ConjunctInfos: 6
   MaxConjunctInfos: 2
@@ -113,7 +110,6 @@ Go:
         "Disjuncts": 2,
         "Notifications": 0,
         "Conjuncts": 8,
-        "CloseIDElems": 0,
         "NumCloseIDs": 2,
         "ConjunctInfos": 6,
         "MaxConjunctInfos": 2,

cue/stats/stats.go

@@ -70,7 +70,6 @@ type Counts struct {
 	Conjuncts int64
 
 	// Typo checking counters
-	CloseIDElems     int64 // Size of ReqSet
 	NumCloseIDs      int64 // Number of close IDs used
 	ConjunctInfos    int64 // Number of conjunct infos created
 	MaxConjunctInfos int64 // Maximum number of conjunct infos in a node
@@ -114,7 +113,6 @@ func (c *Counts) Add(other Counts) {
 	c.Disjuncts += other.Disjuncts
 	c.Notifications += other.Notifications
 
-	c.CloseIDElems += other.CloseIDElems
 	c.NumCloseIDs += other.NumCloseIDs
 	c.ConjunctInfos += other.ConjunctInfos
 	if other.MaxConjunctInfos > c.MaxConjunctInfos {
@@ -135,7 +133,6 @@ func (c Counts) Since(start Counts) Counts {
 	c.Conjuncts -= start.Conjuncts
 	c.Disjuncts -= start.Disjuncts
 	c.Notifications -= start.Notifications
-	c.CloseIDElems -= start.CloseIDElems
 	c.NumCloseIDs -= start.NumCloseIDs
 
 	c.ConjunctInfos -= start.ConjunctInfos

internal/core/adt/eval_test.go

@@ -138,7 +138,7 @@ func runEvalTest(t *cuetxtar.Test, version internal.EvaluatorVersion, dbg cuedeb
 					counts.Disjuncts > 20,
 				orig.Conjuncts > counts.Conjuncts*2,
 				counts.Notifications > 10,
-				counts.CloseIDElems > 1000,
+				counts.NumCloseIDs > 100,
 				counts.Leaks()-orig.Leaks() > 17,
 				counts.Allocs-orig.Allocs > 50:
 				// For now, we only care about disjuncts.

internal/core/adt/typocheck.go

@@ -816,7 +816,6 @@ func (a *reqSets) replaceIDs(ctx *OpContext, b ...replaceID) {
 
 		for qIdx := 0; qIdx < len(queue); qIdx++ {
 			currentSet := queue[qIdx]
-			ctx.stats.CloseIDElems++
 
 			for _, nextID := range index[currentSet.id].replacements {
 				if !index[nextID].delete && !visited.Has(nextID) {