Skip to content

Commit 71220e6

Browse files
committed
cue: ignore some tests for TestPos
The new evalautor reports different, but correct, positions, that are actually better than those of the old evaluator. Issue #3060 Signed-off-by: Marcel van Lohuizen <[email protected]> Change-Id: I56d062eec11d22f5eac1fe8751071cd9f0fbb9a9 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1194057 TryBot-Result: CUEcueckoo <[email protected]> Unity-Result: CUE porcuepine <[email protected]> Reviewed-by: Daniel Martí <[email protected]>
1 parent fa3bf5f commit 71220e6

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

cue/types_test.go

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3235,6 +3235,7 @@ func TestPos(t *testing.T) {
32353235
testCases := []struct {
32363236
value string
32373237
pos string
3238+
skip bool
32383239
}{{
32393240
value: `
32403241
a: string
@@ -3245,6 +3246,10 @@ a: "foo"`,
32453246
a: x: string
32463247
a: x: "x"`,
32473248
pos: "2:4",
3249+
3250+
// the position of the new evaluator is also correct, and actually
3251+
// better.
3252+
skip: true,
32483253
}, {
32493254
// Prefer struct conjuncts with actual fields.
32503255
value: `
@@ -3264,7 +3269,9 @@ a: x: y: z: "x"`,
32643269
}}
32653270
for _, tc := range testCases {
32663271
runMatrix(t, "", func(t *testing.T, cfg *evalConfig) {
3267-
TODO_V3(t, cfg)
3272+
if tc.skip {
3273+
TODO_V3(t, cfg)
3274+
}
32683275

32693276
var c Context
32703277
(*runtime.Runtime)(&c).Init()

0 commit comments

Comments
 (0)