all: use a few more newer std APIs

Noticed in passing at different times and git stashed.
Now that I have a handful, send them out as a single patch.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: I257175f2b404d0d6890aa90e16f723ec55a7f6ac
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1209880
Unity-Result: CUE porcuepine <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Roger Peppe <[email protected]>

Author: mvdan

cmd/cue/cmd/get_go.go

@@ -433,13 +433,12 @@ func (e *extractor) addPackage(p *packages.Package) {
 
 func (e *extractor) recordTypeInfo(p *packages.Package) {
 	for _, f := range p.Syntax {
-		ast.Inspect(f, func(n ast.Node) bool {
+		for n := range ast.Preorder(f) {
 			switch n := n.(type) {
 			case *ast.StructType:
 				e.orig[p.TypesInfo.TypeOf(n)] = n
 			}
-			return true
-		})
+		}
 	}
 }
 

cue/interpreter/wasm/runtime.go

@@ -15,6 +15,7 @@
 package wasm
 
 import (
+	"bytes"
 	"context"
 	"fmt"
 	"os"
@@ -183,11 +184,11 @@ func (m *memory) Bytes() []byte {
 	m.i.mu.Lock()
 	defer m.i.mu.Unlock()
 
-	bytes, ok := m.i.instance.Memory().Read(m.ptr, m.len)
+	p, ok := m.i.instance.Memory().Read(m.ptr, m.len)
 	if !ok {
 		panic(fmt.Sprintf("can't read %d bytes from Wasm address %#x", m.len, m.ptr))
 	}
-	return append([]byte{}, bytes...)
+	return bytes.Clone(p)
 }
 
 // WriteAt writes p at the given relative offset within m.

internal/mod/mvs/mvs.go

@@ -297,7 +297,7 @@ func Upgrade[V comparable](target V, reqs UpgradeReqs[V], upgrade ...V) ([]V, er
 	for _, m := range list {
 		pathInList[reqs.Path(m)] = true
 	}
-	list = append([]V(nil), list...)
+	list = slices.Clone(list)
 
 	upgradeTo := make(map[string]string, len(upgrade))
 	for _, u := range upgrade {

pkg/gen.go

@@ -314,7 +314,7 @@ var (
 
 func (g *generator) genFunc(fn *types.Func) {
 	g.nonConcrete = false
-	sign := fn.Type().(*types.Signature)
+	sign := fn.Signature()
 	if sign.Recv() != nil {
 		return
 	}

pkg/list/list.go

@@ -141,11 +141,7 @@ func Repeat(x []cue.Value, count int) ([]cue.Value, error) {
 	if count < 0 {
 		return nil, fmt.Errorf("negative count")
 	}
-	var a []cue.Value
-	for range count {
-		a = append(a, x...)
-	}
-	return a, nil
+	return slices.Repeat(x, count), nil
 }
 
 // Concat takes a list of lists and concatenates them.
@@ -319,12 +315,7 @@ outer:
 // Contains reports whether v is contained in a. The value must be a
 // comparable value.
 func Contains(a []cue.Value, v cue.Value) bool {
-	for _, w := range a {
-		if v.Equals(w) {
-			return true
-		}
-	}
-	return false
+	return slices.ContainsFunc(a, v.Equals)
 }
 
 // MatchN is a validator that checks that the number of elements in the given