cue: add missing finalization

mpvl · mpvl · commit 4cbb1800466b · 2025-03-26T12:02:40.000Z
In some cases a value may not be finalized. Issue #3825 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: I87143c1b332db8596d8157ae96c8bc2534229315 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1212030 Reviewed-by: Matthew Sackman <matthew@cue.works> TryBot-Result: CUEcueckoo <cueckoo@cuelang.org> Unity-Result: CUE porcuepine <cue.porcuepine@gmail.com>
diff --git a/cue/types.go b/cue/types.go
@@ -1897,6 +1897,7 @@ func reference(rt *runtime.Runtime, c *adt.OpContext, env *adt.Environment, r ad
 	if inst == nil {
 		return nil, nil
 	}
+	inst.Finalize(c)
 	return inst, path
 }
 
diff --git a/encoding/openapi/testdata/issue131.txtar b/encoding/openapi/testdata/issue131.txtar
@@ -1,4 +1,3 @@
-#skip-v3-noshare
 -- in.cue --
 package ext
 

Original file line number	Diff line number	Diff line change
`@@ -1897,6 +1897,7 @@ func reference(rt runtime.Runtime, c adt.OpContext, env *adt.Environment, r ad`
`1897`	`1897`	`if inst == nil {`
`1898`	`1898`	`return nil, nil`
`1899`	`1899`	`}`
	`1900`	`+ inst.Finalize(c)`
`1900`	`1901`	`return inst, path`
`1901`	`1902`	`}`
`1902`	`1903`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-#skip-v3-noshare`
`2`	`1`	`-- in.cue --`
`3`	`2`	`package ext`
`4`	`3`