internal/core/adt: obey internal/core/cuedebug defaults in TestEval

TestEval and TestEvalAlpha were hard-coding cuedebug.Config values,
meaning that they didn't stay in sync with the defaults set by
the cuedebug package via struct field tags.

As such, until very recently, cmd/cue and Go API users of evalv3
were using openinline=1 as a default via cuedebug, but TestEvalAlpha
was ignoring that default and running all tests with openinline=0.

Follow the defaults, and allow overriding it if #openInline is present
at the top of the txtar file. We only override the value if such a line
exists, as otherwise we always replace the default value.

Signed-off-by: Daniel Martí <[email protected]>
Change-Id: Ia004c216cbea5f0124d61abd76d9f893e98d2e99
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1211946
Unity-Result: CUE porcuepine <[email protected]>
Reviewed-by: Marcel van Lohuizen <[email protected]>
TryBot-Result: CUEcueckoo <[email protected]>

Author: mvdan

internal/core/adt/eval_test.go

@@ -53,12 +53,15 @@ func TestEval(t *testing.T) {
 		ToDo: needFix,
 	}
 
+	cuedebug.Init()
+	flags := cuedebug.Flags
+
 	if *todo {
 		test.ToDo = nil
 	}
 
 	test.Run(t, func(tc *cuetxtar.Test) {
-		runEvalTest(tc, internal.DefaultVersion, cuedebug.Config{})
+		runEvalTest(tc, internal.DefaultVersion, flags)
 	})
 }
 
@@ -80,9 +83,8 @@ func TestEvalAlpha(t *testing.T) {
 	//
 	adt.DebugDeps = true // check unmatched dependencies.
 
-	flags := cuedebug.Config{
-		Sharing: true,
-	}
+	cuedebug.Init()
+	flags := cuedebug.Flags
 
 	var todoAlpha = map[string]string{}
 
@@ -137,7 +139,10 @@ func skipFiles(a ...*ast.File) (reason string) {
 }
 
 func runEvalTest(t *cuetxtar.Test, version internal.EvaluatorVersion, flags cuedebug.Config) (errorCount int) {
-	flags.OpenInline = t.Bool("openInline")
+	// If #openInline is set, override the default as set by the cuedebug package.
+	if s, ok := t.Value("openInline"); ok {
+		flags.OpenInline = s == "true"
+	}
 
 	a := t.Instance()
 	r := runtime.NewWithSettings(version, flags)