internal/core/adt: dereference default

Defaults are constructed from final values, so we should
ensure that the value is fully dereferenced before getting
a default.

This fixes most tests of TestFields. We added a per-test
todo field to exclude the rest.

Issue #3060

Signed-off-by: Marcel van Lohuizen <[email protected]>
Change-Id: Iedfcbb679d74f8be39a6ce1ed6109577c969c6c2
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/1193958
TryBot-Result: CUEcueckoo <[email protected]>
Reviewed-by: Daniel Martí <[email protected]>
Unity-Result: CUE porcuepine <[email protected]>

Author: mpvl

cue/types_test.go

@@ -759,6 +759,8 @@ func TestFields(t *testing.T) {
 		res   string
 		err   string
 		opts  []Option
+
+		todoV3 bool
 	}{{
 		value: `{ #def: 1, _hidden: 2, opt?: 3, reg: 4 }`,
 		res:   "{reg:4,}",
@@ -806,13 +808,17 @@ func TestFields(t *testing.T) {
 		if step1.value > 100 {
 		}`,
 		err: "undefined field: value",
+
+		todoV3: true,
 	}, {
 		opts: []Option{Concrete(true)},
 		value: `
 		step1: {}
 		if step1.value > 100 {
 		}`,
 		err: "undefined field: value",
+
+		todoV3: true,
 	}, {
 		value: `{a!: 1, b?: 2, c: 3}`,
 		err:   "a: field is required but not present",
@@ -831,7 +837,9 @@ func TestFields(t *testing.T) {
 	}}
 	for _, tc := range testCases {
 		runMatrix(t, tc.value, func(t *testing.T, cfg *evalConfig) {
-			TODO_V3(t, cfg)
+			if tc.todoV3 {
+				TODO_V3(t, cfg)
+			}
 
 			obj := cfg.getValue(t, tc.value)
 

internal/core/adt/default.go

@@ -45,6 +45,7 @@ func (d *Disjunction) Default() Value {
 //
 // It also closes a list, representing its default value.
 func (v *Vertex) Default() *Vertex {
+	v = v.Indirect()
 	switch d := v.BaseValue.(type) {
 	default:
 		return v