Skip to content

Commit ff7a0c2

Browse files
committed
Gardening: Streamline SeedNode.toString()
Motivation ---------- Want seed nodes to be easier to read when they appear in the logs. Modifications ------------- Omit absent ports from toString() Example output after this change: SeedNode{address='example.com'} SeedNode{address='example.com', kvPort=1234} SeedNode{address='example.com', kvPort=1234, mgmtPort=5678} Change-Id: I1e63b8214ef9102c645cb2e1ba5e26ce099e17d6 Reviewed-on: https://review.couchbase.org/c/couchbase-jvm-clients/+/213545 Tested-by: Build Bot <[email protected]> Reviewed-by: Graham Pople <[email protected]>
1 parent 0defe9b commit ff7a0c2

File tree

1 file changed

+8
-6
lines changed

1 file changed

+8
-6
lines changed

core-io/src/main/java/com/couchbase/client/core/env/SeedNode.java

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -151,12 +151,14 @@ public Optional<Integer> protostellarPort() {
151151

152152
@Override
153153
public String toString() {
154-
return "SeedNode{" +
155-
"address='" + address + '\'' +
156-
", kvPort=" + kvPort +
157-
", mgmtPort=" + clusterManagerPort +
158-
", psPort=" + protostellarPort +
159-
'}';
154+
StringBuilder sb = new StringBuilder("SeedNode{")
155+
.append("address='").append(address).append('\'');
156+
157+
kvPort.ifPresent(port -> sb.append(", kvPort=").append(port));
158+
clusterManagerPort.ifPresent(port -> sb.append(", mgmtPort=").append(port));
159+
protostellarPort.ifPresent(port -> sb.append(", psPort=").append(port));
160+
161+
return sb.append('}').toString();
160162
}
161163

162164
@Override

0 commit comments

Comments
 (0)