Skip to content

Commit ab7599e

Browse files
committed
JVMCBC-1547 (followup) Exclude META-INF/services from repackaged dnsjava
Motivation ---------- Avoid dnsjava/dnsjava#329 We're not interested in overriding the JVM's default DNS lookup mechanisms. All we care about is our own explicit DNS SRV lookups. Modifications ------------- Don't include the `dnsjava` library's `META-INF/services` directory in `core-io-deps`. Change-Id: I851e00843f7ee0702ab59da248fbf7ea514f630a Reviewed-on: https://review.couchbase.org/c/couchbase-jvm-clients/+/213386 Tested-by: David Nault <[email protected]> Reviewed-by: David Nault <[email protected]>
1 parent 92b3d8d commit ab7599e

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

core-io-deps/pom.xml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,10 @@
330330
<excludes>
331331
<!-- These localized messages are optional (See R.java) and aren't worth the trouble of relocating. -->
332332
<resource>messages.properties</resource>
333+
<!-- Avoid https://github.com/dnsjava/dnsjava/issues/329
334+
Also, we're not interested in overriding the JVM's default DNS lookup mechanisms;
335+
we only care about our own explicit DNS SRV lookups. -->
336+
<exclude>META-INF/services/**</exclude>
333337
</excludes>
334338
</filter>
335339
<filter>

0 commit comments

Comments
 (0)