JVMCBC-1477 Improve config loading backoff for bad credentials

Motivation
----------
Prior to this change, providing bad credentials and then
opening a bucket caused the SDK to spam the server with
unauthorized (401) "GET /pools/default/b/<bucket-name>"
requests. These requests flooded the server's
http_access.log.

Modifications
-------------
Add "no access" to the category of errors that get
a longer delay between retries.

Change-Id: I93473c5b08d2d9f12448a8fba2e879ecaa9539cd
Reviewed-on: https://review.couchbase.org/c/couchbase-jvm-clients/+/207418
Tested-by: Build Bot <[email protected]>
Reviewed-by: Michael Reiche <[email protected]>

Author: dnault

core-io/src/main/java/com/couchbase/client/core/config/DefaultConfigurationProvider.java

@@ -48,6 +48,7 @@
 import com.couchbase.client.core.error.BucketNotReadyDuringLoadException;
 import com.couchbase.client.core.error.ConfigException;
 import com.couchbase.client.core.error.CouchbaseException;
+import com.couchbase.client.core.error.NoAccessDuringConfigLoadException;
 import com.couchbase.client.core.error.RequestCanceledException;
 import com.couchbase.client.core.error.SeedNodeOutdatedException;
 import com.couchbase.client.core.error.TimeoutException;
@@ -973,9 +974,10 @@ private Mono<ProposedBucketConfigContext> fetchBucketConfigs(final String name,
 
             boolean bucketNotFound = f instanceof BucketNotFoundDuringLoadException;
             boolean bucketNotReady = f instanceof BucketNotReadyDuringLoadException;
+            boolean noAccess = f instanceof NoAccessDuringConfigLoadException;
 
-            // For bucket not found or not ready wait a bit longer, retry the rest quickly
-            Duration delay = bucketNotFound || bucketNotReady
+            // For some, wait a bit longer; retry the rest quickly.
+            Duration delay = bucketNotFound || bucketNotReady || noAccess
               ? Duration.ofMillis(500)
               : Duration.ofMillis(1);
             eventBus.publish(new BucketOpenRetriedEvent(name, delay, core.context(), f));

core-io/src/main/java/com/couchbase/client/core/config/loader/ClusterManagerBucketLoader.java

@@ -21,7 +21,7 @@
 import com.couchbase.client.core.Reactor;
 import com.couchbase.client.core.error.BucketNotFoundDuringLoadException;
 import com.couchbase.client.core.error.ConfigException;
-import com.couchbase.client.core.msg.ResponseStatus;
+import com.couchbase.client.core.error.NoAccessDuringConfigLoadException;
 import com.couchbase.client.core.msg.manager.BucketConfigRequest;
 import com.couchbase.client.core.node.NodeIdentifier;
 import com.couchbase.client.core.retry.BestEffortRetryStrategy;
@@ -72,10 +72,14 @@ protected Mono<byte[]> discoverConfig(final NodeIdentifier seed, final String bu
     }).map(response -> {
       if (response.status().success()) {
         return response.config();
-      } else if (response.status() == ResponseStatus.NOT_FOUND) {
-        throw new BucketNotFoundDuringLoadException("Bucket [\"" + redactMeta(bucket) + "\"] not found during loading");
-      } else {
-        throw new ConfigException("Received error status from ClusterManagerBucketLoader: " + response);
+      }
+      switch (response.status()) {
+        case NOT_FOUND:
+          throw new BucketNotFoundDuringLoadException("Bucket [\"" + redactMeta(bucket) + "\"] not found during loading");
+        case NO_ACCESS:
+          throw new NoAccessDuringConfigLoadException("Client was denied access to bucket [\"" + redactMeta(bucket) + "\"] during config loading. Common causes include invalid credentials or insufficient permissions.");
+        default:
+          throw new ConfigException("Received error status from ClusterManagerBucketLoader: " + response);
       }
     });
   }

core-io/src/main/java/com/couchbase/client/core/error/NoAccessDuringConfigLoadException.java

@@ -0,0 +1,26 @@
+/*
+ * Copyright 2024 Couchbase, Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package com.couchbase.client.core.error;
+
+import com.couchbase.client.core.annotation.Stability;
+
+@Stability.Internal
+public class NoAccessDuringConfigLoadException extends ConfigException {
+  public NoAccessDuringConfigLoadException(String message) {
+    super(message);
+  }
+}