Forces TTY usage for interactive sessions

Ensures consistent interactive experiences by always enabling TTY. Removes checks for non-interactive terminals to streamline usage.

Author: Twsouza

pkg/cli/exec.go

@@ -1,7 +1,6 @@
 package cli
 
 import (
-	"os"
 	"strings"
 
 	"github.com/convox/rack/pkg/options"
@@ -28,10 +27,7 @@ func Exec(rack sdk.Interface, c *stdcli.Context) error {
 		opts.Height = options.Int(h)
 		opts.Width = options.Int(w)
 	}
-
-	if !stdcli.IsTerminal(os.Stdin) {
-		opts.Tty = options.Bool(false)
-	}
+	opts.Tty = options.Bool(true)
 
 	restore := c.TerminalRaw()
 	defer restore()

pkg/cli/run.go

@@ -2,7 +2,6 @@ package cli
 
 import (
 	"fmt"
-	"os"
 	"strings"
 
 	"github.com/convox/rack/pkg/helpers"
@@ -111,10 +110,8 @@ func Run(rack sdk.Interface, c *stdcli.Context) error {
 		Width:      opts.Width,
 	}
 
-	if !stdcli.IsTerminal(os.Stdin) {
-		eopts.Tty = options.Bool(false)
-	}
-
+	eopts.Tty = options.Bool(true)
+	fmt.Printf("=======> Options: %+v\n", eopts)
 	code, err := rack.ProcessExec(app(c), ps.Id, command, c, eopts)
 	if err != nil {
 		return err

provider/aws/processes.go

@@ -44,38 +44,45 @@ func (p *Provider) ProcessExec(app, pid, command string, rw io.ReadWriter, opts
 			break
 		}
 	}
+	log.Logf("pidFound: %t", pidFound)
+	log.Logf("pid: %s", pid)
 
 	if !pidFound {
+		log.Error(err)
+
 		return -1, errorNotFound(fmt.Sprintf("process id not found for %s", app))
 	}
 
 	dc, err := p.dockerClientFromPid(pid)
 	if err != nil {
-		return -1, err
+		return -1, log.Error(err)
 	}
 
 	c, err := p.dockerContainerFromPid(pid)
 	if err != nil {
-		return -1, err
+		return -1, log.Error(err)
 	}
+	log.Logf("container: %s", c.ID)
 
 	cmd := []string{"sh", "-c", command}
 
 	tty := cb(opts.Tty, true)
+	log.Logf("tty: %t", tty)
 
 	if opts.Entrypoint != nil && *opts.Entrypoint {
 		cmd = append(c.Config.Entrypoint, cmd...)
 	} else {
 		a, err := p.AppGet(app)
 		if err != nil {
-			return -1, err
+			return -1, log.Error(err)
 		}
 
 		if a.Tags["Generation"] == "2" {
 			cmd = append([]string{"/convox-env"}, cmd...)
 		}
 	}
 
+	log.Logf("Command: %s", commandString(cmd))
 	eres, err := dc.CreateExec(docker.CreateExecOptions{
 		AttachStdin:  true,
 		AttachStdout: true,
@@ -93,7 +100,10 @@ func (p *Provider) ProcessExec(app, pid, command string, rw io.ReadWriter, opts
 	go func() {
 		<-success
 		if opts.Height != nil && opts.Width != nil {
-			dc.ResizeExecTTY(eres.ID, *opts.Height, *opts.Width)
+			err := dc.ResizeExecTTY(eres.ID, *opts.Height, *opts.Width)
+			if err != nil {
+				log.Error(err)
+			}
 		}
 		success <- struct{}{}
 	}()
@@ -104,7 +114,7 @@ func (p *Provider) ProcessExec(app, pid, command string, rw io.ReadWriter, opts
 		InputStream:  io.NopCloser(rw),
 		OutputStream: rw,
 		ErrorStream:  rw,
-		RawTerminal:  true,
+		RawTerminal:  tty,
 		Success:      success,
 	})
 
@@ -116,6 +126,7 @@ func (p *Provider) ProcessExec(app, pid, command string, rw io.ReadWriter, opts
 	if err != nil {
 		return -1, log.Error(err)
 	}
+	log.Logf("ExitCode: %d", ires.ExitCode)
 
 	return ires.ExitCode, log.Success()
 }