Catch error on creating snapshot and log error

Relates to: #1663

Signed-off-by: Michael Engel <[email protected]>

Author: engelmi

ramalama/model_store/store.py

@@ -306,7 +306,6 @@ def new_snapshot(self, model_tag: str, snapshot_hash: str, snapshot_files: list[
             self.remove_snapshot(model_tag)
             raise ex
         except Exception as ex:
-            perror(f"Failed to create new snapshot: {ex}")
             perror("Removing snapshot...")
             self.remove_snapshot(model_tag)
             raise ex

ramalama/ollama.py

@@ -160,7 +160,10 @@ def pull(self, args):
             self.print_pull_message(f"ollama://{name}:{tag}")
 
         model_hash = ollama_repo.get_model_hash(manifest)
-        self.model_store.new_snapshot(tag, model_hash, files)
+        try:
+            self.model_store.new_snapshot(tag, model_hash, files)
+        except Exception as ex:
+            perror(f"Failed to create snapshot for {name}:{tag} : {ex}")
 
         # If a model has been downloaded via ollama cli, only create symlink in the snapshots directory
         if is_model_in_ollama_cache:

ramalama/url.py

@@ -1,7 +1,7 @@
 import os
 import shutil
 
-from ramalama.common import generate_sha256
+from ramalama.common import generate_sha256, perror
 from ramalama.huggingface import HuggingfaceRepository
 from ramalama.model import Model
 from ramalama.model_store.snapshot_file import SnapshotFile, SnapshotFileType
@@ -105,6 +105,9 @@ def pull(self, args):
                 )
             )
 
-        self.model_store.new_snapshot(tag, snapshot_hash, files)
+        try:
+            self.model_store.new_snapshot(tag, snapshot_hash, files)
+        except Exception as ex:
+            perror(f"Failed to create snapshot for {name}:{tag} : {ex}")
 
         return self.model_store.get_snapshot_file_path(snapshot_hash, name)