Skip to content

Commit 7bdd073

Browse files
authored
Merge pull request #1491 from makllama/xd/fix_hf
Fix #1489
2 parents 5925bb6 + ae0775a commit 7bdd073

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

ramalama/hf_style_repo_base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,7 @@ def fetch_checksum_from_api(self, organization, file):
182182
pass
183183

184184
@abstractmethod
185-
def create_repository(self, name, organization, tag='latest'):
185+
def create_repository(self, name, organization, tag):
186186
"""Create repository instance"""
187187
pass
188188

@@ -328,9 +328,9 @@ def _pull_with_model_store(self, args):
328328

329329
try:
330330
if not args.quiet:
331-
self.print_pull_message(f"{self.get_repo_type()}://{name}:{tag}")
331+
self.print_pull_message(f"{self.get_repo_type()}://{organization}/{name}:{tag}")
332332

333-
repo = self.create_repository(name, organization)
333+
repo = self.create_repository(name, organization, tag)
334334
snapshot_hash = repo.model_hash
335335
files = repo.get_file_list(cached_files)
336336
self.store.new_snapshot(tag, snapshot_hash, files)

ramalama/huggingface.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,8 +165,11 @@ def get_repo_type(self):
165165
def fetch_checksum_from_api(self, organization, file):
166166
return fetch_checksum_from_api(organization, file)
167167

168-
def create_repository(self, name, organization, tag='latest'):
169-
return HuggingfaceRepositoryModel(name, organization, tag)
168+
def create_repository(self, name, organization, tag):
169+
if '/' in organization:
170+
return HuggingfaceRepositoryModel(name, organization, tag)
171+
else:
172+
return HuggingfaceRepository(name, organization, tag)
170173

171174
def get_download_url(self, directory, filename):
172175
return f"https://huggingface.co/{directory}/resolve/main/{filename}"

ramalama/modelscope.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def get_repo_type(self):
8080
def fetch_checksum_from_api(self, organization, file):
8181
return fetch_checksum_from_api(organization, file)
8282

83-
def create_repository(self, name, organization, tag='latest'):
83+
def create_repository(self, name, organization, tag):
8484
return ModelScopeRepository(name, organization, tag)
8585

8686
def get_download_url(self, directory, filename):

0 commit comments

Comments
 (0)