Skip to content

Commit e62f77c

Browse files
committed
run.bats(run --mount): skip if we're on overlay
If we're on overlayfs, we can't use the directory name that we'd like to use as part of the test and expect things to succeed, even if we try to work around it using fuse-overlayfs. Signed-off-by: Nalin Dahyabhai <[email protected]>
1 parent 7122d05 commit e62f77c

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

tests/run.bats

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -419,6 +419,12 @@ function configure_and_check_user() {
419419
run_buildah from --quiet --pull=false $WITH_POLICY_JSON alpine
420420
cid=$output
421421
mkdir -p ${TEST_SCRATCH_DIR}/was:empty
422+
if $(stat -f -c %T ${TEST_SCRATCH_DIR}/chroot/upperdir) = overlayfs; then
423+
# we'll try to use fuse-overlayfs, which at least through 1.13
424+
# can't accept ":" in layer locations, escaped or not, so bail
425+
# now instead of breaking the whole thing
426+
skip unable to test bind from an overlay location that includes colon characters
427+
fi
422428
# As a baseline, this should succeed.
423429
run_buildah run --mount type=tmpfs,dst=/var/tmpfs-not-empty $cid touch /var/tmpfs-not-empty/testfile
424430
# This should succeed, but the writes should effectively be discarded

0 commit comments

Comments
 (0)